linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, david@redhat.com,
	lorenzo.stoakes@oracle.com, ziy@nvidia.com,
	baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org
Subject: Re: [Patch v2 2/2] mm/huge_memory: Optimize and simplify __split_unmapped_folio() logic
Date: Fri, 17 Oct 2025 00:55:55 +0000	[thread overview]
Message-ID: <20251017005555.snztmz6hawkcwkpk@master> (raw)
In-Reply-To: <20251016004613.514-3-richard.weiyang@gmail.com>

On Thu, Oct 16, 2025 at 12:46:13AM +0000, Wei Yang wrote:
>Existing __split_unmapped_folio() code splits the given folio and update
>stats, but it is complicated to understand.
>
>After simplification, __split_unmapped_folio() directly calculate and
>update the folio statistics upon a successful split:
>
>* All resulting folios are @split_order.
>
>* The number of new folios are calculated directly from @old_order
>  and @split_order.
>
>* The folio for the next split is identified as the one containing
>  @split_at.
>
>* An xas_try_split() error is returned directly without worrying
>  about stats updates.

@Andrew

From David and Zi comment, there is little change in change log.

Would you mind helping update it? Below is the updated version.

---

    Existing __split_unmapped_folio() code splits the given folio and
    updates stats, but it is complicated to understand.
    
    After simplification, __split_unmapped_folio() directly calculates and
    updates the folio statistics upon a successful split:
    
    * All resulting folios are @split_order.
    
    * The number of new folios are calculated directly from @old_order and
      @split_order.
    
    * The folio for the next split is identified as the one containing
      @split_at.
    
    * Stats fixup is no longer needed for an xas_try_split() error,
      since since we now update the stats only after a successful split.

-- 
Wei Yang
Help you, Help me


  parent reply	other threads:[~2025-10-17  0:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  0:46 [Patch v2 0/2] mm/huge_memory: cleanup __split_unmapped_folio() Wei Yang
2025-10-16  0:46 ` [Patch v2 1/2] mm/huge_memory: cache folio attribute in __split_unmapped_folio() Wei Yang
2025-10-16  1:34   ` Barry Song
2025-10-16 20:01   ` David Hildenbrand
2025-10-17  9:46   ` Lorenzo Stoakes
2025-10-19  7:51     ` Wei Yang
2025-10-16  0:46 ` [Patch v2 2/2] mm/huge_memory: Optimize and simplify __split_unmapped_folio() logic Wei Yang
2025-10-16  1:25   ` wang lian
2025-10-16 20:10   ` David Hildenbrand
2025-10-16 20:22     ` Zi Yan
2025-10-16 20:55       ` David Hildenbrand
2025-10-16 20:56         ` Zi Yan
2025-10-17  0:55   ` Wei Yang [this message]
2025-10-17  9:44   ` Lorenzo Stoakes
2025-10-17 14:26     ` Zi Yan
2025-10-17 14:29       ` Zi Yan
2025-10-17 14:44       ` Lorenzo Stoakes
2025-10-17 14:45       ` David Hildenbrand
2025-10-17 14:55         ` Lorenzo Stoakes
2025-10-17 17:24           ` Zi Yan
2025-10-20 14:03             ` Lorenzo Stoakes
2025-10-20 14:28               ` Zi Yan
2025-10-21  0:30               ` Wei Yang
2025-10-21  9:17                 ` Lorenzo Stoakes
2025-10-19  8:00           ` Wei Yang
2025-10-20 11:55             ` Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251017005555.snztmz6hawkcwkpk@master \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox