From: Andrew Morton <akpm@linux-foundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
David Hildenbrand <david@redhat.com>, <linux-mm@kvack.org>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
<Liam.Howlett@oracle.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [PATCH v3 1/3] mm: mprotect: always skip dma pinned folio in prot_numa_skip()
Date: Thu, 16 Oct 2025 14:10:51 -0700 [thread overview]
Message-ID: <20251016141051.27e9ce8b47aa242724ae97a4@linux-foundation.org> (raw)
In-Reply-To: <0d26ce96-2c59-47bd-a034-d7810ce6aa5f@huawei.com>
On Thu, 16 Oct 2025 09:00:34 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> On 2025/10/15 23:32, Lorenzo Stoakes wrote:
> > On Wed, Oct 15, 2025 at 08:35:14PM +0800, Kefeng Wang wrote:
> >> If the folio(even not CoW folio) is dma pinned, it can't be
> >> migrated, so always skip pinned folio to avoid a waste of cycles
> >> when folios migration.
> >
> > NIT: 'when folios migration' -> 'when folios are migrated'.
> >
> > Maybe worth saying 'due to elevated reference count?'
> >
>
> Hope Andrew could help to update the changelog.
>
I changed it to this:
: If the folio (even not CoW folio) is dma pinned, it can't be migrated
: due to the elevated reference count. So always skip a pinned folio to
: avoid wasting cycles when folios are migrated.
next prev parent reply other threads:[~2025-10-16 21:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 12:35 [PATCH v3 0/3] mm: some optimizations for prot numa Kefeng Wang
2025-10-15 12:35 ` [PATCH v3 1/3] mm: mprotect: always skip dma pinned folio in prot_numa_skip() Kefeng Wang
2025-10-15 15:32 ` Lorenzo Stoakes
2025-10-16 1:00 ` Kefeng Wang
2025-10-16 21:10 ` Andrew Morton [this message]
2025-10-17 8:46 ` Lorenzo Stoakes
2025-10-17 14:12 ` Kefeng Wang
2025-10-16 1:14 ` Zi Yan
2025-10-16 17:53 ` Dev Jain
2025-10-15 12:35 ` [PATCH v3 2/3] mm: mprotect: avoid unnecessary struct page accessing if pte_protnone() Kefeng Wang
2025-10-15 15:43 ` Lorenzo Stoakes
2025-10-15 17:45 ` David Hildenbrand
2025-10-16 1:07 ` Kefeng Wang
2025-10-17 8:47 ` Lorenzo Stoakes
2025-10-17 8:46 ` Lorenzo Stoakes
2025-10-16 1:28 ` Zi Yan
2025-10-16 1:35 ` Kefeng Wang
2025-10-16 18:02 ` Dev Jain
2025-10-15 12:35 ` [PATCH v3 3/3] mm: huge_memory: use folio_needs_prot_numa() for pmd folio Kefeng Wang
2025-10-16 19:19 ` David Hildenbrand
2025-10-17 10:07 ` Lorenzo Stoakes
2025-10-17 14:13 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016141051.27e9ce8b47aa242724ae97a4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
--cc=sidhartha.kumar@oracle.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox