From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98CE5CCD199 for ; Wed, 15 Oct 2025 18:17:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF62E8E0080; Wed, 15 Oct 2025 14:17:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA63E8E006F; Wed, 15 Oct 2025 14:17:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D73DD8E0080; Wed, 15 Oct 2025 14:17:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C00F88E006F for ; Wed, 15 Oct 2025 14:17:47 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 70A25140218 for ; Wed, 15 Oct 2025 18:17:47 +0000 (UTC) X-FDA: 84001156974.30.9B78A17 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by imf22.hostedemail.com (Postfix) with ESMTP id 6797BC0017 for ; Wed, 15 Oct 2025 18:17:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=f1PeSLWV; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf22.hostedemail.com: domain of boris.brezillon@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1760552265; a=rsa-sha256; cv=none; b=UOS4XdfL6ub8edMAW5Xq++tvcs/KxaILXkn/v2OEzUXAyNKrCB1SjLkdBvZQsUYq5xNdHU vmMFiDv0VpVPW26NUXnpcjwcuawH2pEQDLKr8qfH7kwoMVci2QauFWSPzFf/oW8oQzVRxn joXKMOSTcN5kFv2k5uCOpYi2nOAf4Lc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=f1PeSLWV; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf22.hostedemail.com: domain of boris.brezillon@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1760552265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8DFIEwRuQ3Yi4HFc4u4ALmoD2K65fwco7Fg940WqFjU=; b=dl9eHzveFoVOt0k7Pr/zZsU/ktMf1/UE5WZRlxJX3lJqMNlawg97zvZXx1TWtkX2NmsyRz Il+IpfW5KLDJCRopCJbPYnizekMAzEmLgd98fiCM9LdfNVQtqkNHQkNDxGGwduOjXd2n4K zgyoMBDT/VQxwkFNOcaNTK2wQmsKUDQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1760552262; bh=7ptcchgLxwIkPXE05LECg/WjIoBNqSmV17ABYHJJQkY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f1PeSLWViiy6lxbY6mDbjfWggl+sS8rbLqvJXDcrtvzph1hKk1BhB+QzIrCa6yeuT fXE0WRi9qr1C1SM75AnWVeYxLlsYCj/rxVLmDhYF8BA7TwYpaBgyTmWJg5RPbPcp/r wxpE5vmB/QJLrvrmJvKTnyQFMc/vDnm7uETEX1UuPc62pvjquSIhJ0hHCL1pKnupj1 /0XwcrIohZ/b19Kh3Ft5phd6lAa0acTCj5hnlsr0kFGVExMLJ8PMM5VcV6AB937jPN 80KENnV6aVcCTM7MjFBIJ66Erqljq4yCO7RQj41W/AfL79LXOMywQoTDzVT8j9yMjh iViOcUEBUGKQQ== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 557FD17E0125; Wed, 15 Oct 2025 20:17:41 +0200 (CEST) Date: Wed, 15 Oct 2025 20:17:37 +0200 From: Boris Brezillon To: =?UTF-8?B?TG/Dr2M=?= Molinari Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?B?TWHDrXJh?= Canal , Hugh Dickins , Baolin Wang , Andrew Morton , Al Viro , =?UTF-8?B?TWlrb8WCYWo=?= Wasiak , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v4 08/13] drm/v3d: Fix builds with CONFIG_TRANSPARENT_HUGEPAGE=n Message-ID: <20251015201737.3956f801@fedora> In-Reply-To: <20251015153018.43735-9-loic.molinari@collabora.com> References: <20251015153018.43735-1-loic.molinari@collabora.com> <20251015153018.43735-9-loic.molinari@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: fzomtn7e8e6xwraifqd5zc9koti4iyh9 X-Rspamd-Queue-Id: 6797BC0017 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1760552265-652059 X-HE-Meta: U2FsdGVkX1+rjN5qcsZ2s3I12irYAz1vAa8LDKQcV2DROvbgmtbdGA1hy4N6Q0+e/hcxdc+jdytw5OaqN7V9FRkqWjCuxinYiYUe/dH2Q2YWIEiNjZ+xcwMSbKRTyv5sx08PQHsh9QnGBp21hGP8pIpr6qoYIG+yNFB06P3dpy0K/WSt5I7kJy5emqlSM9kjedEANGrMnS818r2LHpbUQBsjATs55zya6vwSzD8DUn7mLrRVLBk5iPqj38aP7RcTb9JuTnDe+CRzi9sMRdSMIAsmrCmb76RdtqYyLnIwJf4UKAHnPxG1vWHhoVz6WftyQiYF9LSVpU6sox/SEuP7LGfLJ2p0uCAFbR475y25sZr7ANRijvOGk9oO9Gakkjf7vCRhXBUtwedFalRYP/m7KNT45qL4bCHDcyFFP4FlFlwI4dfUm1+S+o9G1U+LpZomy3snTnQu1Y8oRNy46xv+oY+xuNj2Q054unHC+R1m4LZueC0bL/OiM7RPQYgnQK9NMI09vTI2Pvxh41MELoOmxjOtfnF5ADslQ4RgcKlaUycJgYJxubApj8Ki6eKuG3tPcmxsMKQyra0VAa+7isv4ph5AW2Vx6yKMMyUBIE7PPVSj8MAhAXIOrC+Zy4ta3WIlrlWNMn3Yc1x/2lHDuHZu8bxUoI0lxLzNMT9klU2B+uXK7hnKM0k4KJYpJALFseqaweLAQeqbWfxSdlh6IycdafQ+DHy4QQddglj8C99sKhsJDSubFYn0s2UeZEX0SrWby41Tc+3Qg/lLtWajZeUFMYKufzOvgY6ne/5sw9VmmUB7+OwL6YYx+ickuZ9wI2W+y0DVEBgMWf6on8kgZhNGVKGRGh8qHN7/CzpkTNGbhdq2x/dGOSYlM2O2T4YPomsuda6yoapjv4LrD4CVX5xvq64vYlYzclI1njCDmrlXfSpQ7f5MglYXFrzd/xX+YdCNCW3dGfgqN5xFsN6hSG1 tSfUM4fp dv+YX7NkNzycoEEwDhOGiI1ajgFnz/pHltGSr+OOu9kCguQ32pUtUNJjYMM9BpvCfmTB4OiQHkVekaVWaglqyO/EXPC6HSHwRG5Fq2JlthlfkrFoQxYaHD7/a4TTLFyAD1+eDgawugvJD3tOxQFtk7hu4wUQXsN049/rWt4IglldJPqYizIVN06ODVr8CinpvsYfsItzQ5EaSmYfKbyBR1BX0C9CHwb0PXG4VJ9FmofM5NKDSDVEf2BYfo1rK/xG5QhFXPWAbppbnWFS5zFrPnYxd8fjHKUQp44U+XJ4HEXRqXUnd10+GX7XMm2KEK/VWLcu1MRLXN4Kr/hzEhQXw68ZxuuF+VqzjXu8y+ZwXlsqxQZsYI8tXgpR2fB0kMKSF1B7C3Tj1ed76altbZqPSPmR87ME0uE7XmbWwpWSbgQmORHw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 15 Oct 2025 17:30:12 +0200 Lo=C3=AFc Molinari wrote: > Don't declare "super_pages" on builds with CONFIG_TRANSPARENT_HUGEPAGE > disabled to prevent build error: >=20 > ERROR: modpost: "super_pages" [drivers/gpu/drm/v3d/v3d.ko] undefined! I believe this is a bug introduced by the previous commit: the compiler probably drops any code between the IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) check and the err label because IS_ENABLED() evaluates to false at compile time. So I'd squash those changes in the previous commit. >=20 > Signed-off-by: Lo=C3=AFc Molinari > --- > drivers/gpu/drm/v3d/v3d_drv.h | 2 ++ > drivers/gpu/drm/v3d/v3d_gem.c | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h > index 99a39329bb85..481502104391 100644 > --- a/drivers/gpu/drm/v3d/v3d_drv.h > +++ b/drivers/gpu/drm/v3d/v3d_drv.h > @@ -564,7 +564,9 @@ extern const struct dma_fence_ops v3d_fence_ops; > struct dma_fence *v3d_fence_create(struct v3d_dev *v3d, enum v3d_queue q= ); > =20 > /* v3d_gem.c */ > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > extern bool super_pages; > +#endif > int v3d_gem_init(struct drm_device *dev); > void v3d_gem_destroy(struct drm_device *dev); > void v3d_reset_sms(struct v3d_dev *v3d); > diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c > index 635ff0fabe7e..0039063eb8b2 100644 > --- a/drivers/gpu/drm/v3d/v3d_gem.c > +++ b/drivers/gpu/drm/v3d/v3d_gem.c > @@ -269,7 +269,9 @@ v3d_huge_mnt_init(struct v3d_dev *v3d) > * match our usecase. > */ > =20 > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > if (super_pages) > +#endif > err =3D drm_gem_huge_mnt_create(&v3d->drm, "within_size"); Why not #ifdef CONFIG_TRANSPARENT_HUGEPAGE if (super_pages) err =3D drm_gem_huge_mnt_create(&v3d->drm, "within_size"); #endif I guess if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && super_pages) err =3D drm_gem_huge_mnt_create(&v3d->drm, "within_size"); would also do, since it's likely to rely on the same optimization the previous v3d_gemfs_init() implementation was relying on, but it's fragile (not sure what happens when compiled with -O0). > =20 > if (v3d->drm.huge_mnt)