From: "Darrick J. Wong" <djwong@kernel.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: akpm@linux-foundation.org, linux-mm <linux-mm@kvack.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: Regression in generic/749 with 8k fsblock size on 6.18-rc1
Date: Wed, 15 Oct 2025 10:45:32 -0700 [thread overview]
Message-ID: <20251015174532.GB6188@frogsfrogsfrogs> (raw)
In-Reply-To: <d2b367ae-b339-429b-a5e7-1d179cfa0695@app.fastmail.com>
On Wed, Oct 15, 2025 at 08:39:53AM +0100, Kirill A. Shutemov wrote:
> On Tue, Oct 14, 2025, at 18:52, Darrick J. Wong wrote:
> > Did your testing also demonstrate this regression?
>
> I have not reproduced the issue yet.
>
> Could you check if this patch makes a difference:
>
> https://gist.github.com/kiryl/a2c71057bec332240216cc425aca791a
Yes, it does make the test failure go away:
FSTYP -- xfs (debug)
PLATFORM -- Linux/x86_64 alder-mtr00 6.18.0-rc1-xfsx #rc1 SMP PREEMPT_DYNAMIC Wed Oct 15 10:34:11 PDT 2025
MKFS_OPTIONS -- -f -b size=8192, /dev/sdf
MOUNT_OPTIONS -- -o uquota,gquota,pquota, /dev/sdf /opt
generic/749 9s
Ran: generic/749
Passed all 1 tests
Is it valid to i_size_read() in the two places you add them? I /think/
the folio is locked in the filemap.c hunk. I'm not as sure about the
finish_fault changes. If the EOF folio's locked then I think it's the
case that anything trying to change the file size will block until the
folio lock drops.
<shrug> Thanks for your help, in any case :)
--D
> --
> Kiryl Shutsemau / Kirill A. Shutemov
>
next prev parent reply other threads:[~2025-10-15 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 17:52 Darrick J. Wong
2025-10-15 7:39 ` Kirill A. Shutemov
2025-10-15 17:45 ` Darrick J. Wong [this message]
2025-10-15 15:59 ` Kiryl Shutsemau
2025-10-15 17:57 ` Darrick J. Wong
2025-10-16 10:22 ` Kiryl Shutsemau
2025-10-16 22:33 ` Dave Chinner
2025-10-17 14:28 ` Kiryl Shutsemau
2025-10-17 16:02 ` Darrick J. Wong
2025-10-17 17:00 ` Kiryl Shutsemau
2025-10-17 17:14 ` Matthew Wilcox
2025-10-21 17:02 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015174532.GB6188@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox