From: Deepanshu Kartikey <kartikey406@gmail.com>
To: =muchun.song@linux.dev, osalvador@suse.de,
akpm@linux-foundation.org, broonie@kernel.org, david@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzbot+f26d7c75c26ec19790e7@syzkaller.appspotmail.com
Subject: Re: [PATCH v4] hugetlbfs: check for shareable lock before calling huge_pmd_unshare()
Date: Mon, 13 Oct 2025 15:03:08 +0530 [thread overview]
Message-ID: <20251013093308.4412-1-kartikey406@gmail.com> (raw)
Hi David,
That makes a lot of sense - moving the assertions after the early return
checks is cleaner since the locks are only needed when actual unsharing
work happens.
Should I send a v5 with your suggested change?
Thanks,
Deepanshu
next reply other threads:[~2025-10-13 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 9:33 Deepanshu Kartikey [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-13 9:33 Deepanshu Kartikey
2025-10-13 9:54 ` David Hildenbrand
2025-10-13 13:12 ` Oscar Salvador
2025-10-13 14:22 ` Deepanshu Kartikey
2025-10-03 17:45 [PATCH v3] hugetlbfs: skip PMD unsharing when shareable lock unavailable Deepanshu Kartikey
2025-10-08 5:27 ` [PATCH v4] hugetlbfs: check for shareable lock before calling huge_pmd_unshare() Deepanshu Kartikey
2025-10-13 8:09 ` Oscar Salvador
2025-10-13 8:27 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013093308.4412-1-kartikey406@gmail.com \
--to=kartikey406@gmail.com \
--cc==muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=syzbot+f26d7c75c26ec19790e7@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox