From: Jakub Acs <acsjakub@amazon.de>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>, <llvm@lists.linux.dev>,
<oe-kbuild-all@lists.linux.dev>,
Linux Memory Management List <linux-mm@kvack.org>,
Miguel Ojeda <ojeda@kernel.org>,
Alice Ryhl <aliceryhl@google.com>
Subject: Re: [akpm-mm:mm-new 36/102] error[E0425]: cannot find value `VM_READ` in crate `bindings`
Date: Fri, 10 Oct 2025 06:07:08 +0000 [thread overview]
Message-ID: <20251010060618.GA80465@dev-dsk-acsjakub-1b-6f9934e2.eu-west-1.amazon.com> (raw)
In-Reply-To: <CANiq72kKSz=UK+O4tnV0Kmw_HmJhJJ+KNZnUBWtOWqanrG+7Vg@mail.gmail.com>
On Thu, Oct 09, 2025 at 08:14:01PM +0200, Miguel Ojeda wrote:
> On Thu, Oct 9, 2025 at 8:05 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > Alice, Miguel, please remind what to do about this?
>
> We can either define helper constants in
> `rust/bindings/bindings_helper.h` for the ones that the Rust side is
> already using (like last time) or use `enum`s on the C header.
FWIW Alice suggested the enum version and we discussed adjustment to the
patch in thread [1]. I was going to send new version of the patch as
soon as I figure out how to test for the issue pointed out by Derrick in
[2].
Please let me know if that is desired or whether you're taking care of
it here. And/or how else I can help.
[1]: https://lore.kernel.org/all/20251008125427.68735-1-acsjakub@amazon.de/
[2]: https://lore.kernel.org/all/20251007170156.GQ1587915@frogsfrogsfrogs/
Thanks,
Jakub
Amazon Web Services Development Center Germany GmbH
Tamara-Danz-Str. 13
10243 Berlin
Geschaeftsfuehrung: Christian Schlaeger
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597
next prev parent reply other threads:[~2025-10-10 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 17:42 kernel test robot
2025-10-09 18:05 ` Andrew Morton
2025-10-09 18:14 ` Miguel Ojeda
2025-10-09 18:15 ` Miguel Ojeda
2025-10-09 19:23 ` Andrew Morton
2025-10-10 6:07 ` Jakub Acs [this message]
2025-10-10 6:59 ` Miguel Ojeda
2025-10-10 7:44 ` Jakub Acs
2025-10-10 8:13 ` Miguel Ojeda
2025-10-10 8:19 ` Miguel Ojeda
2025-10-10 7:47 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010060618.GA80465@dev-dsk-acsjakub-1b-6f9934e2.eu-west-1.amazon.com \
--to=acsjakub@amazon.de \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox