linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <bhe@redhat.com>
Cc: linux-mm@kvack.org, chrisl@kernel.org, kasong@tencent.com,
	baohua@kernel.org, nphamcs@gmail.com, shikemeng@huaweicloud.com
Subject: Re: [PATCH 3/3] mm/swap: remove unneeded swap_active_head
Date: Thu, 9 Oct 2025 18:28:40 -0700	[thread overview]
Message-ID: <20251009182840.55426eb0548e7da1b721d4fc@linux-foundation.org> (raw)
In-Reply-To: <aOdoehPH1O2vJnqv@MiWiFi-R3L-srv>

On Thu, 9 Oct 2025 15:47:06 +0800 Baoquan He <bhe@redhat.com> wrote:

> On 10/08/25 at 08:26pm, Andrew Morton wrote:
> > On Wed,  1 Oct 2025 12:34:36 +0800 Baoquan He <bhe@redhat.com> wrote:
> > 
> > > There's no user of swap_active_head, remove it now.
> > > 
> > > ...
> > >
> > > @@ -2553,8 +2545,6 @@ static void _enable_swap_info(struct swap_info_struct *si)
> > >  
> > >  	assert_spin_locked(&swap_lock);
> > >  
> > > -	plist_add(&si->list, &swap_active_head);
> > > -
> > 
> > There's a large comment in _enable_swap_info() which needs to be
> > removed or updated?
> 
> This patchset depends on below patchset:
> [PATCH v3 0/2] mm/swapfile.c: select the swap device with default priority round robin

Oh, OK, sorry, missed that.

(When I'm working on the post-merge-window patch pile (700+ emails) I
go in reverse-time order, so highlighting dependencies like this helps!)

> By the way, Chris worried the plist swap_active_head could be reused by
> the ongoing swap-tier work and suggested to hold off this patchset till
> swap-tier work is clear. Now seems it won't impact swap-tier, I will
> send a v2 against mm-new.

OK.

Is Baoquan's "[PATCH v3 0/2] mm/swapfile.c: select the swap device with
default priority round robin" series still considered good to merge?


  parent reply	other threads:[~2025-10-10  1:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01  4:34 [PATCH 0/3] mm/swap: remove plist swap_active_head Baoquan He
2025-10-01  4:34 ` [PATCH 1/3] mm/swapfile.c: remove __has_usable_swap() Baoquan He
2025-10-01  4:34 ` [PATCH 2/3] mm/swapfile.c: use swap_info[] to find the swap device Baoquan He
2025-10-02 15:59   ` Chris Li
2025-10-03  2:38     ` Baoquan He
2025-10-03  4:50       ` Chris Li
2025-10-03  5:29         ` Baoquan He
2025-10-01  4:34 ` [PATCH 3/3] mm/swap: remove unneeded swap_active_head Baoquan He
2025-10-02  8:33   ` Chris Li
2025-10-02 13:42     ` Baoquan He
2025-10-09  3:26   ` Andrew Morton
2025-10-09  7:47     ` Baoquan He
2025-10-09 17:09       ` Chris Li
2025-10-10  2:56         ` YoungJun Park
2025-10-10  1:28       ` Andrew Morton [this message]
2025-10-10  2:14         ` Baoquan He
2025-10-10  2:34           ` Chris Li
2025-10-10  2:33         ` Chris Li
2025-10-10  2:52         ` Chris Li
2025-10-02  6:04 ` [PATCH 0/3] mm/swap: remove plist swap_active_head Chris Li
2025-10-02 13:09   ` Baoquan He
2025-10-02 16:23     ` Chris Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251009182840.55426eb0548e7da1b721d4fc@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=bhe@redhat.com \
    --cc=chrisl@kernel.org \
    --cc=kasong@tencent.com \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox