From: SeongJae Park <sj@kernel.org>
To: Kiryl Shutsemau <kas@kernel.org>
Cc: SeongJae Park <sj@kernel.org>, Dmitry Ilvokhin <d@ilvokhin.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Kairui Song <kasong@tencent.com>, Nhat Pham <nphamcs@gmail.com>,
Baoquan He <bhe@redhat.com>, Barry Song <baohua@kernel.org>,
Chris Li <chrisl@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Usama Arif <usamaarif642@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH v2] mm: skip folio_activate() for mlocked folios
Date: Wed, 8 Oct 2025 09:29:01 -0700 [thread overview]
Message-ID: <20251008162901.6652-1-sj@kernel.org> (raw)
In-Reply-To: <x6u2afqqwqpoabtpq24n64owlwagolt63csvaibg33p6t2ywuf@beayabw66enb>
On Wed, 8 Oct 2025 11:33:01 +0100 Kiryl Shutsemau <kas@kernel.org> wrote:
> On Tue, Oct 07, 2025 at 12:53:13PM -0700, SeongJae Park wrote:
> > On Mon, 6 Oct 2025 13:25:26 +0000 Dmitry Ilvokhin <d@ilvokhin.com> wrote:
> >
> > > __mlock_folio() does not move folio to unevicable LRU, when
> > > folio_activate() removes folio from LRU.
> >
> > A trivial opinion. So the user-visible issue is the incorrect meminfo, right?
>
> The user-visible effect is that we unnecessary postpone moving pages to
> unevictable LRU that lead to unexpected stats: Mlocked > Unevictable.
Thank you for clarifying!
>
> > > ---
> > > Changes in v2:
> > > - Rephrase commit message: frame it in terms of unevicable LRU, not stat
> > > accounting.
> >
> > Yet another trivial and personal opinion. Adding a link to the previous
> > version could be helpful for reviewers like me.
>
> You probably missed recent Linus rant on Link: tags :P
I didn't miss it [1] :) And I pretty sure Linus wouldn't be angry for this,
since what he dislikes is meaningless Link: tags on commit messages. We are
discussing something about changelog after the '---' line, which will anyway
not added to the commit message. Also I'm saying a link in a general form, not
specifically Link: tag.
[1] https://lwn.net/Articles/1037069/
Thanks,
SJ
[...]
next prev parent reply other threads:[~2025-10-08 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 13:25 Dmitry Ilvokhin
2025-10-07 16:26 ` Nhat Pham
2025-10-07 19:53 ` SeongJae Park
2025-10-08 10:33 ` Kiryl Shutsemau
2025-10-08 16:29 ` SeongJae Park [this message]
2025-10-08 16:17 ` Shakeel Butt
2025-10-08 18:06 ` Dmitry Ilvokhin
2025-10-15 19:59 ` Andrew Morton
2025-10-15 20:09 ` Dmitry Ilvokhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008162901.6652-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=d@ilvokhin.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shikemeng@huaweicloud.com \
--cc=usamaarif642@gmail.com \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox