Re: [Patch v2] mm/khugepaged: unify pmd folio installation with map_anon_folio_pmd()

[Wei Yang <richard.weiyang@gmail.com>]

On Tue, Oct 07, 2025 at 10:59:33AM -0400, Zi Yan wrote:
>On 7 Oct 2025, at 9:11, Dev Jain wrote:
>
>> On 07/10/25 5:54 pm, Lance Yang wrote:
>>>
>>>
>>> On 2025/10/7 17:54, Dev Jain wrote:
>>>>
>>>> On 07/10/25 9:36 am, Anshuman Khandual wrote:
>>>>>
>>>>> On 07/10/25 6:20 AM, Wei Yang wrote:
>>>>>> Currently we install pmd folio with map_anon_folio_pmd() in
>>>>>> __do_huge_pmd_anonymous_page() and do_huge_zero_wp_pmd(). While in
>>>>>> collapse_huge_page(), it is done with identical code except statistics
>>>>>> adjustment.
>>>>>>
>>>>>> Unify the process with map_anon_folio_pmd() to install pmd folio. Split
>>>>>> it to map_anon_folio_pmd_pf() and map_anon_folio_pmd_nopf() to be used
>>>>>> in page fault or not respectively.
>>>>>>
>>>>>> No functional change is intended.
>>>>>>
>>>>>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>>>>>> Cc: David Hildenbrand <david@redhat.com>
>>>>>> Cc: Lance Yang <lance.yang@linux.dev>
>>>>>> Cc: Dev Jain <dev.jain@arm.com>
>>>>>> Cc: Zi Yan <ziy@nvidia.com>
>>>>>> Cc: Usama Arif <usamaarif642@gmail.com>
>>>>>> Cc: Matthew Wilcox <willy@infradead.org>
>>>>>>
>>>>>> ---
>>>>>> v2:
>>>>>>    * split to map_anon_folio_pmd_[no]pf() suggested by Matthew
>>>>> On which branch this patch applies against ?
>>>>
>>>> +1, does not apply on mm-new for me. There have been multiple patches
>>>> changing the same file so it will be beneficial to say what commit
>>>> it applies against.
>>>
>>> I think this patch applies on top of the patch[1], which is based on mm-new.
>>>
>>> [1] https://lore.kernel.org/linux-mm/20251002013825.20448-1-richard.weiyang@gmail.com
>>
>> Thanks, but this is not yet in mm-new. There are some unaddressed comments there.
>>
>> Wei, please resend this patch based on mm-new. I would urge you to hold off sending
>>
>> multiple patches all of which change the same file and have close dependency, till the
>>
>> first one gets merged.

Sorry for the unconvenience.

>
>Or just send both patches in a series to show the dependency. That makes
>reviewers’ lives much easier.
>

Thanks, this is a good suggestion. Will resend them together.

>Best Regards,
>Yan, Zi

-- 
Wei Yang
Help you, Help me