* [PATCH] mm/vmscan: Remove redundant __GFP_NOWARN
@ 2025-10-05 12:43 Fushuai Wang
2025-10-05 21:12 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Fushuai Wang @ 2025-10-05 12:43 UTC (permalink / raw)
To: akpm, hannes, david, mhocko, zhengqi.arch, shakeel.butt,
lorenzo.stoakes, axelrasmussen, yuanchu, weixugc
Cc: linux-mm, linux-kernel, Fushuai Wang
The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
remove the redundant __GFP_NOWARN flag.
Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
mm/vmscan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index b2fc8b626d3d..2acb3c09fe0d 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1054,8 +1054,8 @@ static unsigned int demote_folio_list(struct list_head *demote_folios,
* When this happens, 'page' will likely just be discarded
* instead of migrated.
*/
- .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN |
- __GFP_NOMEMALLOC | GFP_NOWAIT,
+ .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOMEMALLOC |
+ GFP_NOWAIT,
.nid = target_nid,
.nmask = &allowed_mask,
.reason = MR_DEMOTION,
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/vmscan: Remove redundant __GFP_NOWARN
2025-10-05 12:43 [PATCH] mm/vmscan: Remove redundant __GFP_NOWARN Fushuai Wang
@ 2025-10-05 21:12 ` Matthew Wilcox
2025-10-06 1:39 ` Fushuai Wang
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2025-10-05 21:12 UTC (permalink / raw)
To: Fushuai Wang
Cc: akpm, hannes, david, mhocko, zhengqi.arch, shakeel.butt,
lorenzo.stoakes, axelrasmussen, yuanchu, weixugc, linux-mm,
linux-kernel
On Sun, Oct 05, 2025 at 08:43:29PM +0800, Fushuai Wang wrote:
> - .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN |
> - __GFP_NOMEMALLOC | GFP_NOWAIT,
> + .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOMEMALLOC |
> + GFP_NOWAIT,
Please just remove the NOWARN. There's no need to reflow the other
flags and break the 80 column limit.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/vmscan: Remove redundant __GFP_NOWARN
2025-10-05 21:12 ` Matthew Wilcox
@ 2025-10-06 1:39 ` Fushuai Wang
0 siblings, 0 replies; 3+ messages in thread
From: Fushuai Wang @ 2025-10-06 1:39 UTC (permalink / raw)
To: willy
Cc: akpm, axelrasmussen, david, hannes, linux-kernel, linux-mm,
lorenzo.stoakes, mhocko, shakeel.butt, wangfushuai, weixugc,
yuanchu, zhengqi.arch
>> - .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN |
>> - __GFP_NOMEMALLOC | GFP_NOWAIT,
>> + .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOMEMALLOC |
>> + GFP_NOWAIT,
>
> Please just remove the NOWARN. There's no need to reflow the other
> flags and break the 80 column limit.
OK, I will send a v2 shortly.
Regards,
Wang.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-06 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-05 12:43 [PATCH] mm/vmscan: Remove redundant __GFP_NOWARN Fushuai Wang
2025-10-05 21:12 ` Matthew Wilcox
2025-10-06 1:39 ` Fushuai Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox