linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Fushuai Wang <wangfushuai@baidu.com>
To: <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <axelrasmussen@google.com>,
	<david@redhat.com>, <hannes@cmpxchg.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<lorenzo.stoakes@oracle.com>, <mhocko@kernel.org>,
	<shakeel.butt@linux.dev>, <wangfushuai@baidu.com>,
	<weixugc@google.com>, <yuanchu@google.com>,
	<zhengqi.arch@bytedance.com>
Subject: Re: [PATCH] mm/vmscan: Remove redundant __GFP_NOWARN
Date: Mon, 6 Oct 2025 09:39:11 +0800	[thread overview]
Message-ID: <20251006013911.43917-1-wangfushuai@baidu.com> (raw)
In-Reply-To: <aOLfOUgoEskd8jyE@casper.infradead.org>

>> -		.gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN |
>> -			__GFP_NOMEMALLOC | GFP_NOWAIT,
>> +		.gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOMEMALLOC |
>> +			GFP_NOWAIT,
>
> Please just remove the NOWARN.  There's no need to reflow the other
> flags and break the 80 column limit.

OK, I will send a v2 shortly.

Regards,
Wang.


      reply	other threads:[~2025-10-06  1:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-05 12:43 Fushuai Wang
2025-10-05 21:12 ` Matthew Wilcox
2025-10-06  1:39   ` Fushuai Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251006013911.43917-1-wangfushuai@baidu.com \
    --to=wangfushuai@baidu.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=yuanchu@google.com \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox