From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Loïc Molinari" <loic.molinari@collabora.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Rob Herring" <robh@kernel.org>,
"Steven Price" <steven.price@arm.com>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Melissa Wen" <mwen@igalia.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Hugh Dickins" <hughd@google.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Mikołaj Wasiak" <mikolaj.wasiak@intel.com>,
"Christian Brauner" <brauner@kernel.org>,
"Nitin Gote" <nitin.r.gote@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-mm@kvack.org,
kernel@collabora.com
Subject: Re: [PATCH 2/8] drm/gem: Introduce drm_gem_get_unmapped_area() fop
Date: Tue, 30 Sep 2025 12:45:54 +0200 [thread overview]
Message-ID: <20250930124554.5459194c@fedora> (raw)
In-Reply-To: <20250930123003.75370854@fedora>
On Tue, 30 Sep 2025 12:30:03 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> > +unsigned long drm_gem_get_unmapped_area(struct file *filp, unsigned long uaddr,
> > + unsigned long len, unsigned long pgoff,
> > + unsigned long flags)
> > +{
> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > + struct drm_gem_object *obj;
> > + unsigned long ret;
> > +
> > + obj = drm_gem_object_lookup_from_offset(filp, pgoff, len >> PAGE_SHIFT);
> > + if (IS_ERR(obj))
>
> Is this supposed to happen? If not, I'd be tempted to add a
> WARN_ON_ONCE().
Taking that back. I think you need it for non-GEM backed mappings, like
userland IOMEM mappings.
>
> > + return mm_get_unmapped_area(current->mm, filp, uaddr, len, 0,
> > + flags);
> > +
next prev parent reply other threads:[~2025-09-30 10:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 20:03 [PATCH 0/8] drm: Optimize page tables overhead with THP Loïc Molinari
2025-09-29 20:03 ` [PATCH 1/8] drm/shmem-helper: Add huge page fault handler Loïc Molinari
2025-09-29 20:03 ` [PATCH 2/8] drm/gem: Introduce drm_gem_get_unmapped_area() fop Loïc Molinari
2025-09-30 10:05 ` kernel test robot
2025-09-30 10:30 ` Boris Brezillon
2025-09-30 10:45 ` Boris Brezillon [this message]
2025-09-30 16:09 ` Loïc Molinari
2025-09-30 16:29 ` Boris Brezillon
2025-09-30 16:42 ` Loïc Molinari
2025-09-29 20:03 ` [PATCH 3/8] drm/shmem-helper: Add huge tmpfs mount point helpers Loïc Molinari
2025-09-30 10:57 ` Boris Brezillon
2025-09-29 20:03 ` [PATCH 4/8] drm/i915: Use " Loïc Molinari
2025-09-30 11:06 ` kernel test robot
2025-09-29 20:03 ` [PATCH 5/8] drm/v3d: " Loïc Molinari
2025-09-29 20:03 ` [PATCH 6/8] drm/panthor: Introduce huge tmpfs mount point option Loïc Molinari
2025-09-30 10:34 ` Boris Brezillon
2025-09-30 16:31 ` Loïc Molinari
2025-09-30 16:52 ` Boris Brezillon
2025-10-04 9:39 ` Loïc Molinari
2025-09-30 10:36 ` kernel test robot
2025-09-29 20:03 ` [PATCH 7/8] drm/panthor: Improve IOMMU map/unmap debugging logs Loïc Molinari
2025-09-30 10:37 ` Boris Brezillon
2025-09-29 20:03 ` [PATCH 8/8] drm/panfrost: Introduce huge tmpfs mount point option Loïc Molinari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930124554.5459194c@fedora \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liviu.dudau@arm.com \
--cc=loic.molinari@collabora.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mikolaj.wasiak@intel.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=nitin.r.gote@intel.com \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox