From: SeongJae Park <sj@kernel.org>
To: Sidharth Seela <sidharthseela@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
nphamcs@gmail.com, hannes@cmpxchg.org, nathan@kernel.org,
shuah@kernel.org, morbo@google.com, justinstitt@google.com,
nick.desaulniers+lkml@gmail.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, david.hunter.linux@gmail.com
Subject: Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under label
Date: Mon, 29 Sep 2025 10:27:24 -0700 [thread overview]
Message-ID: <20250929172724.75108-1-sj@kernel.org> (raw)
In-Reply-To: <20250929115405.25695-2-sidharthseela@gmail.com>
On Mon, 29 Sep 2025 17:24:06 +0530 Sidharth Seela <sidharthseela@gmail.com> wrote:
> Fix warning caused from declaration under a case label. The proper way
> is to declare variable at the beginning of the function. The warning
> came from running clang using LLVM=1; and is as follows:
> --
> -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
> 260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
> |
>
> Signed-off-by: Sidharth Seela <sidharthseela@gmail.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2025-09-29 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 11:54 Sidharth Seela
2025-09-29 17:27 ` SeongJae Park [this message]
2025-09-30 3:31 ` lianux
2025-10-10 20:07 ` Shuah Khan
2025-10-20 17:13 ` Nhat Pham
2025-09-30 4:52 ` Dev Jain
2025-10-22 15:27 ` Shuah Khan
2025-10-23 15:04 ` Sidharth Seela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250929172724.75108-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nphamcs@gmail.com \
--cc=shuah@kernel.org \
--cc=sidharthseela@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox