Re: [PATCH 1/3] mm/page_owner: add option 'print_handle' for 'show_stacks'

[Joshua Hahn <joshua.hahnjy@gmail.com>]

On Wed, 24 Sep 2025 14:40:21 -0300 Mauricio Faria de Oliveira <mfo@igalia.com> wrote:

> For monitoring the memory usage per stack trace, it is more efficient to
> use the handle number as unique identifier of a stack trace than to, for
> example, read/hash all stack traces to uniquely identify them everytime.
> 
> The handle number is a unique identifier for stack traces in stackdepot.
> 
> This patch adds the option 'print_handle' to print the handle number of
> stack traces in 'show_stacks'.

> @@ -887,6 +887,7 @@ static void *stack_next(struct seq_file *m, void *v, loff_t *ppos)
>  }
>  
>  static unsigned long page_owner_pages_threshold;
> +static bool page_owner_print_handle;

Hi Mauricio,

Quick nit -- If I understand your cover letter correctly, you want
page_owner_print_handle to be false by default, should we initialize this
to false?

Have a great day!
Joshua

Sent using hkml (https://github.com/sjp38/hackermail)