From: zhongjinji <zhongjinji@honor.com>
To: <akpm@linux-foundation.org>
Cc: <vbabka@suse.cz>, <surenb@google.com>, <mhocko@suse.com>,
<jackmanb@google.com>, <hannes@cmpxchg.org>, <ziy@nvidia.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<liulu.liu@honor.com>, <feng.han@honor.com>,
<zhongjinji@honor.com>
Subject: [PATCH v0] mm/page_alloc: Cleanup for __del_page_from_free_list()
Date: Thu, 25 Sep 2025 16:50:06 +0800 [thread overview]
Message-ID: <20250925085006.23684-1-zhongjinji@honor.com> (raw)
It is unnecessary to set page->private in __del_page_from_free_list().
If the page is about to be allocated, page->private will be cleared by
post_alloc_hook() before the page is handed out. If the page is expanded
or merged, page->private will be reset by set_buddy_order, and no one
will retrieve the page's buddy_order without the PageBuddy flag being set.
If the page is isolated, it will also reset page->private when it
succeeds.
Since __del_page_from_free_list() is a hot path in the kernel, it would be
better to remove the unnecessary set_page_private().
Signed-off-by: zhongjinji <zhongjinji@honor.com>
---
mm/page_alloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index d1d037f97c5f..1999eb7e7c14 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -868,7 +868,6 @@ static inline void __del_page_from_free_list(struct page *page, struct zone *zon
list_del(&page->buddy_list);
__ClearPageBuddy(page);
- set_page_private(page, 0);
zone->free_area[order].nr_free--;
if (order >= pageblock_order && !is_migrate_isolate(migratetype))
--
2.17.1
next reply other threads:[~2025-09-25 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 8:50 zhongjinji [this message]
2025-09-30 13:55 ` Vlastimil Babka
2025-09-30 14:28 ` Zi Yan
2025-09-30 15:20 ` Vlastimil Babka
2025-09-30 15:28 ` Zi Yan
2025-10-01 4:38 ` jinji zhong
2025-10-03 15:18 ` Zi Yan
2025-10-20 15:06 ` jinji zhong
2025-10-20 19:55 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925085006.23684-1-zhongjinji@honor.com \
--to=zhongjinji@honor.com \
--cc=akpm@linux-foundation.org \
--cc=feng.han@honor.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liulu.liu@honor.com \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox