From: Wei Yang <richard.weiyang@gmail.com>
To: Lance Yang <lance.yang@linux.dev>
Cc: akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, ioworker0@gmail.com, kirill@shutemov.name,
hughd@google.com, mpenttil@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH mm-new v2 1/2] mm: make is_guard_pte_marker() available for hugepage collapse
Date: Tue, 23 Sep 2025 02:29:01 +0000 [thread overview]
Message-ID: <20250923022901.mzjqkrkdrwn2r7n2@master> (raw)
In-Reply-To: <20250918050431.36855-2-lance.yang@linux.dev>
On Thu, Sep 18, 2025 at 01:04:30PM +0800, Lance Yang wrote:
>From: Lance Yang <lance.yang@linux.dev>
>
>The hugepage collapsing code needs is_guard_pte_marker() to correctly
>handle PTE guard markers. Move the helper to a shared header and expose
>it.
>
>While at it, simplify the implementation. The current code is redundant
>as it effectively expands to:
>
> is_swap_pte(pte) &&
> is_pte_marker_entry(...) && // from is_pte_marker()
> is_pte_marker_entry(...) // from is_guard_swp_entry()
>
>While a modern compiler could likely optimize this away, let's have clean
>code and not rely on it.
>
>Cc: Kairui Song <kasong@tencent.com>
>Acked-by: David Hildenbrand <david@redhat.com>
>Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>Signed-off-by: Lance Yang <lance.yang@linux.dev>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2025-09-23 2:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 5:04 [PATCH mm-new v2 0/2] mm/khugepaged: optimize collapse candidate detection Lance Yang
2025-09-18 5:04 ` [PATCH mm-new v2 1/2] mm: make is_guard_pte_marker() available for hugepage collapse Lance Yang
2025-09-18 19:07 ` Zi Yan
2025-09-23 2:29 ` Wei Yang [this message]
2025-09-18 5:04 ` [PATCH mm-new v2 2/2] mm/khugepaged: abort collapse scan on guard PTEs Lance Yang
2025-09-18 7:37 ` Dev Jain
2025-09-18 8:11 ` Lance Yang
2025-09-18 10:06 ` Lorenzo Stoakes
2025-09-18 11:10 ` Dev Jain
2025-09-18 10:16 ` Lorenzo Stoakes
2025-09-18 11:11 ` Dev Jain
2025-09-18 18:47 ` David Hildenbrand
2025-09-19 2:41 ` Lance Yang
2025-09-19 7:57 ` David Hildenbrand
2025-09-19 8:26 ` Lance Yang
2025-09-19 4:11 ` Dev Jain
2025-09-18 19:12 ` Zi Yan
2025-09-19 2:44 ` Lance Yang
2025-09-19 3:18 ` Baolin Wang
2025-09-19 3:34 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923022901.mzjqkrkdrwn2r7n2@master \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=kasong@tencent.com \
--cc=kirill@shutemov.name \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mpenttil@redhat.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox