From: Andrew Morton <akpm@linux-foundation.org>
To: "yanjun.zhu" <yanjun.zhu@linux.dev>
Cc: Mike Rapoport <rppt@kernel.org>, Alexander Graf <graf@amazon.com>,
Baoquan He <bhe@redhat.com>,
Changyuan Lyu <changyuanl@google.com>,
Chris Li <chrisl@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] kho: add support for preserving vmalloc allocations
Date: Mon, 22 Sep 2025 16:08:36 -0700 [thread overview]
Message-ID: <20250922160836.8d0dc984ff0986b3809c9ab0@linux-foundation.org> (raw)
In-Reply-To: <8f893019-bd87-4f54-8238-acd8fdeed051@linux.dev>
On Mon, 22 Sep 2025 15:31:42 -0700 "yanjun.zhu" <yanjun.zhu@linux.dev> wrote:
> > +int kho_preserve_vmalloc(void *ptr, struct kho_vmalloc *preservation)
> > +{
> > + struct kho_vmalloc_chunk *chunk;
> > + struct vm_struct *vm = find_vm_area(ptr);
> > + unsigned int order, flags, nr_contig_pages;
> > + unsigned int idx = 0;
> > + int err;
>
> This is a trivial issue. I’m not sure whether RCT (Reverse Christmas
> Trees) is used in the Linux MM mailing list.
Not as far as I know. Some like it.
If I was to have a preference I'd suggest that things be laid out in a
logical order rather than by column count. Group like things together,
avoid use of unintialized storage in initializers(!).
next prev parent reply other threads:[~2025-09-22 23:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 5:44 [PATCH v5 0/4] " Mike Rapoport
2025-09-21 5:44 ` [PATCH v5 1/4] kho: check if kho is finalized in __kho_preserve_order() Mike Rapoport
2025-09-21 5:44 ` [PATCH v5 2/4] kho: replace kho_preserve_phys() with kho_preserve_pages() Mike Rapoport
2025-09-22 13:14 ` Jason Gunthorpe
2025-09-22 13:50 ` Pratyush Yadav
2025-09-21 5:44 ` [PATCH v5 3/4] kho: add support for preserving vmalloc allocations Mike Rapoport
2025-09-22 13:19 ` Jason Gunthorpe
2025-09-22 21:34 ` Andrew Morton
2025-09-24 15:28 ` Pratyush Yadav
2025-09-24 21:00 ` Andrew Morton
2025-09-25 11:22 ` Pratyush Yadav
2025-09-22 13:50 ` Pratyush Yadav
2025-09-22 14:17 ` Pasha Tatashin
2025-09-22 21:23 ` Andrew Morton
2025-09-22 22:31 ` yanjun.zhu
2025-09-22 23:08 ` Andrew Morton [this message]
2025-09-23 5:04 ` Zhu Yanjun
2025-09-21 5:44 ` [PATCH v5 4/4] lib/test_kho: use kho_preserve_vmalloc instead of storing addresses in fdt Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922160836.8d0dc984ff0986b3809c9ab0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=changyuanl@google.com \
--cc=chrisl@kernel.org \
--cc=graf@amazon.com \
--cc=jgg@nvidia.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox