From: Al Viro <viro@zeniv.linux.org.uk>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: Max Kellermann <max.kellermann@ionos.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
ceph-devel@vger.kernel.org
Subject: Re: Need advice with iput() deadlock during writeback
Date: Wed, 17 Sep 2025 21:14:08 +0100 [thread overview]
Message-ID: <20250917201408.GX39973@ZenIV> (raw)
In-Reply-To: <CAGudoHEqNYWMqDiogc9Q_s9QMQHB6Rm_1dUzcC7B0GFBrqS=1g@mail.gmail.com>
On Wed, Sep 17, 2025 at 10:59:23AM +0200, Mateusz Guzik wrote:
> A sketch, incomplete:
> static DECLARE_DELAYED_WORK(delayed_ceph_iput_work, delayed_ceph_iput);
>
> static void __ceph_iput_async(struct callback_head *work)
> {
> struct ceph_inode_info *ci = container_of(work, struct
> ceph_inode_info, async_task_work);
> iput(&ci->netfs.inode);
> }
>
> void ceph_iput_async(struct ceph_inode_info *ci)
> {
> struct inode *inode = &ci->netfs.inode;
>
> if (atomic_add_unless(&inode->i_count, -1, 1))
> return;
>
> if (likely(!in_interrupt() && !(task->flags & PF_KTHREAD))) {
> init_task_work(&ci->async_task_work, __ceph_iput_async);
> if (!task_work_add(task, &ci->async_task_work, TWA_RESUME))
> return;
> }
>
> if (llist_add(&ci->async_llist, &delayed_ceph_iput_list))
> schedule_delayed_work(&delayed_ceph_iput_work, 1);
> }
Looks rather dangerous - what do you do on fs shutdown?
next prev parent reply other threads:[~2025-09-17 20:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 8:07 Max Kellermann
2025-09-17 8:23 ` Mateusz Guzik
2025-09-17 8:38 ` Max Kellermann
2025-09-17 8:59 ` Mateusz Guzik
2025-09-17 9:20 ` Max Kellermann
2025-09-17 9:32 ` Mateusz Guzik
2025-09-17 12:48 ` Max Kellermann
2025-09-17 20:14 ` Al Viro [this message]
2025-09-17 20:19 ` Max Kellermann
2025-09-17 20:29 ` Al Viro
2025-09-17 20:32 ` Max Kellermann
2025-09-17 20:23 ` Mateusz Guzik
2025-09-17 20:34 ` Al Viro
2025-09-17 20:36 ` Max Kellermann
2025-09-17 21:10 ` Al Viro
2025-09-17 21:19 ` Max Kellermann
2025-09-17 21:20 ` Mateusz Guzik
2025-09-17 20:39 ` Mateusz Guzik
2025-09-17 21:02 ` Al Viro
2025-09-17 21:18 ` Mateusz Guzik
2025-09-17 21:42 ` Al Viro
2025-09-17 22:58 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917201408.GX39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=max.kellermann@ionos.com \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox