From: Andrew Morton <akpm@linux-foundation.org>
To: SeongJae Park <sj@kernel.org>
Cc: Quanmin Yan <yanquanmin1@huawei.com>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, wangkefeng.wang@huawei.com,
zuoze1@huawei.com, Chris Mason <clm@fb.com>
Subject: Re: [PATCH v3 11/11] mm/damon: add damon_ctx->min_sz_region
Date: Wed, 17 Sep 2025 14:29:00 -0700 [thread overview]
Message-ID: <20250917142900.e2915812cd94d9a2b0da3987@linux-foundation.org> (raw)
In-Reply-To: <20250917160041.53187-1-sj@kernel.org>
On Wed, 17 Sep 2025 09:00:41 -0700 SeongJae Park <sj@kernel.org> wrote:
> On Thu, 28 Aug 2025 10:12:42 -0700 SeongJae Park <sj@kernel.org> wrote:
>
> > From: Quanmin Yan <yanquanmin1@huawei.com>
> >
> > Adopting addr_unit would make DAMON_MINREGION 'addr_unit * 4096'
> > bytes and cause data alignment issues[1].
> >
> > Add damon_ctx->min_sz_region to change DAMON_MIN_REGION from a global
> > macro value to per-context variable.
> >
> > [1] https://lore.kernel.org/all/527714dd-0e33-43ab-bbbd-d89670ba79e7@huawei.com
>
> I think I found an issue of this patch. Please refer to the attaching patch
> for details.
>
> This patch is in the mm tree and not yet merged into the mainline. Andrew,
> could you please add the attached patch as a fixup of this one?
The flawed patch is actually in mm.git's mm-stable branch, which is
supposedly non-rebasing. So I queued this patch as separate commit, with
Fixes: d8f867fa0825 ("mm/damon: add damon_ctx->min_sz_region")
prev parent reply other threads:[~2025-09-17 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 17:12 [PATCH v3 00/11] mm/damon: support ARM32 with LPAE SeongJae Park
2025-08-28 17:12 ` [PATCH v3 01/11] mm/damon/core: add damon_ctx->addr_unit SeongJae Park
2025-08-28 17:12 ` [PATCH v3 02/11] mm/damon/paddr: support addr_unit for access monitoring SeongJae Park
2025-08-28 17:12 ` [PATCH v3 03/11] mm/damon/paddr: support addr_unit for DAMOS_PAGEOUT SeongJae Park
2025-08-28 17:12 ` [PATCH v3 04/11] mm/damon/paddr: support addr_unit for DAMOS_LRU_[DE]PRIO SeongJae Park
2025-08-28 17:12 ` [PATCH v3 05/11] mm/damon/paddr: support addr_unit for MIGRATE_{HOT,COLD} SeongJae Park
2025-08-28 17:12 ` [PATCH v3 06/11] mm/damon/paddr: support addr_unit for DAMOS_STAT SeongJae Park
2025-08-28 17:12 ` [PATCH v3 07/11] mm/damon/sysfs: implement addr_unit file under context dir SeongJae Park
2025-08-28 17:12 ` [PATCH v3 08/11] Docs/mm/damon/design: document 'address unit' parameter SeongJae Park
2025-08-28 17:12 ` [PATCH v3 09/11] Docs/admin-guide/mm/damon/usage: document addr_unit file SeongJae Park
2025-08-28 17:12 ` [PATCH v3 10/11] Docs/ABI/damon: " SeongJae Park
2025-08-28 17:12 ` [PATCH v3 11/11] mm/damon: add damon_ctx->min_sz_region SeongJae Park
2025-09-17 16:00 ` SeongJae Park
2025-09-17 21:29 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917142900.e2915812cd94d9a2b0da3987@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yanquanmin1@huawei.com \
--cc=zuoze1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox