linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Ethan Graham <ethan.w.s.graham@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
	ethangraham@google.com, glider@google.com, andreyknvl@gmail.com,
	andy@kernel.org, brauner@kernel.org, brendan.higgins@linux.dev,
	davem@davemloft.net, davidgow@google.com, dhowells@redhat.com,
	dvyukov@google.com, elver@google.com,
	herbert@gondor.apana.org.au, ignat@cloudflare.com, jack@suse.cz,
	jannh@google.com, johannes@sipsolutions.net,
	kasan-dev@googlegroups.com, kees@kernel.org,
	kunit-dev@googlegroups.com, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	lukas@wunner.de, rmoar@google.com, shuah@kernel.org,
	tarasmadan@google.com
Subject: Re: [PATCH v1 04/10] tools: add kfuzztest-bridge utility
Date: Wed, 17 Sep 2025 06:26:25 -0700	[thread overview]
Message-ID: <20250917132625.61081-1-sj@kernel.org> (raw)
In-Reply-To: <20250916090109.91132-5-ethan.w.s.graham@gmail.com>

On Tue, 16 Sep 2025 09:01:03 +0000 Ethan Graham <ethan.w.s.graham@gmail.com> wrote:

> From: Ethan Graham <ethangraham@google.com>
> 
> Introduce the kfuzztest-bridge tool, a userspace utility for sending
> structured inputs to KFuzzTest harnesses via debugfs.
> 
> The bridge takes a textual description of the expected input format, a
> file containing random bytes, and the name of the target fuzz test. It
> parses the description, encodes the random data into the binary format
> expected by the kernel, and writes the result to the corresponding
> debugfs entry.
> 
> This allows for both simple manual testing and integration with
> userspace fuzzing engines. For example, it can be used for smoke testing
> by providing data from /dev/urandom, or act as a bridge for blob-based
> fuzzers (e.g., AFL) to target KFuzzTest harnesses.

Thank you for doing this great work, Ethan!  I think this will be very helpful
for finding bugs of DAMON.

> 
> Signed-off-by: Ethan Graham <ethangraham@google.com>
> 
> ---
> v3:
> - Add additional context in header comment of kfuzztest-bridge/parser.c.
> - Add some missing NULL checks.
> - Refactor skip_whitespace() function in input_lexer.c.
> - Use ctx->minalign to compute correct region alignment, which is read
>   from /sys/kernel/debug/kfuzztest/_config/minalign.
> ---
> ---
>  tools/Makefile                        |  15 +-
>  tools/kfuzztest-bridge/.gitignore     |   2 +
>  tools/kfuzztest-bridge/Build          |   6 +
>  tools/kfuzztest-bridge/Makefile       |  48 ++++
>  tools/kfuzztest-bridge/bridge.c       | 103 +++++++
>  tools/kfuzztest-bridge/byte_buffer.c  |  87 ++++++
>  tools/kfuzztest-bridge/byte_buffer.h  |  31 ++
>  tools/kfuzztest-bridge/encoder.c      | 391 +++++++++++++++++++++++++
>  tools/kfuzztest-bridge/encoder.h      |  16 ++
>  tools/kfuzztest-bridge/input_lexer.c  | 242 ++++++++++++++++
>  tools/kfuzztest-bridge/input_lexer.h  |  57 ++++
>  tools/kfuzztest-bridge/input_parser.c | 395 ++++++++++++++++++++++++++
>  tools/kfuzztest-bridge/input_parser.h |  81 ++++++
>  tools/kfuzztest-bridge/rand_stream.c  |  77 +++++
>  tools/kfuzztest-bridge/rand_stream.h  |  57 ++++
>  15 files changed, 1602 insertions(+), 6 deletions(-)
>  create mode 100644 tools/kfuzztest-bridge/.gitignore
>  create mode 100644 tools/kfuzztest-bridge/Build
>  create mode 100644 tools/kfuzztest-bridge/Makefile
>  create mode 100644 tools/kfuzztest-bridge/bridge.c
>  create mode 100644 tools/kfuzztest-bridge/byte_buffer.c
>  create mode 100644 tools/kfuzztest-bridge/byte_buffer.h
>  create mode 100644 tools/kfuzztest-bridge/encoder.c
>  create mode 100644 tools/kfuzztest-bridge/encoder.h
>  create mode 100644 tools/kfuzztest-bridge/input_lexer.c
>  create mode 100644 tools/kfuzztest-bridge/input_lexer.h
>  create mode 100644 tools/kfuzztest-bridge/input_parser.c
>  create mode 100644 tools/kfuzztest-bridge/input_parser.h
>  create mode 100644 tools/kfuzztest-bridge/rand_stream.c
>  create mode 100644 tools/kfuzztest-bridge/rand_stream.h

I'm wondering if it makes sense to put the files under tools/testing/ like
kselftest and kunit.


Thanks,
SJ

[...]


  parent reply	other threads:[~2025-09-17 13:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16  9:00 [PATCH v1 0/10] KFuzzTest: a new kernel fuzzing framework Ethan Graham
2025-09-16  9:01 ` [PATCH v1 01/10] mm/kasan: implement kasan_poison_range Ethan Graham
2025-09-16  9:34   ` Alexander Potapenko
2025-09-16  9:01 ` [PATCH v1 02/10] kfuzztest: add user-facing API and data structures Ethan Graham
2025-09-16  9:58   ` Alexander Potapenko
2025-09-16  9:01 ` [PATCH v1 03/10] kfuzztest: implement core module and input processing Ethan Graham
2025-09-16 10:21   ` Alexander Potapenko
2025-09-17  3:59   ` kernel test robot
2025-09-18  1:21   ` kernel test robot
2025-09-16  9:01 ` [PATCH v1 04/10] tools: add kfuzztest-bridge utility Ethan Graham
2025-09-16 13:42   ` Alexander Potapenko
2025-09-17 13:26   ` SeongJae Park [this message]
2025-09-16  9:01 ` [PATCH v1 05/10] kfuzztest: add ReST documentation Ethan Graham
2025-09-16  9:01 ` [PATCH v1 06/10] kfuzztest: add KFuzzTest sample fuzz targets Ethan Graham
2025-09-18  3:17   ` kernel test robot
2025-09-16  9:01 ` [PATCH v1 07/10] crypto: implement KFuzzTest targets for PKCS7 and RSA parsing Ethan Graham
2025-09-16 10:28   ` Ignat Korchagin
2025-09-17 23:37   ` kernel test robot
2025-09-18  6:52   ` kernel test robot
2025-09-18 14:15   ` Alexander Potapenko
2025-09-16  9:01 ` [PATCH v1 08/10] drivers/auxdisplay: add a KFuzzTest for parse_xy() Ethan Graham
2025-09-16  9:01 ` [PATCH v1 09/10] fs/binfmt_script: add KFuzzTest target for load_script Ethan Graham
2025-09-17  5:04   ` kernel test robot
2025-09-16  9:01 ` [PATCH v1 10/10] MAINTAINERS: add maintainer information for KFuzzTest Ethan Graham
2025-09-16  9:38   ` Alexander Potapenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917132625.61081-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=andreyknvl@gmail.com \
    --cc=andy@kernel.org \
    --cc=brauner@kernel.org \
    --cc=brendan.higgins@linux.dev \
    --cc=davem@davemloft.net \
    --cc=davidgow@google.com \
    --cc=dhowells@redhat.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=ethan.w.s.graham@gmail.com \
    --cc=ethangraham@google.com \
    --cc=glider@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@cloudflare.com \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kasan-dev@googlegroups.com \
    --cc=kees@kernel.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lukas@wunner.de \
    --cc=rmoar@google.com \
    --cc=shuah@kernel.org \
    --cc=tarasmadan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox