From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 2/7] mm/damon/stat: use damon_initialized()
Date: Mon, 15 Sep 2025 20:35:06 -0700 [thread overview]
Message-ID: <20250916033511.116366-3-sj@kernel.org> (raw)
In-Reply-To: <20250916033511.116366-1-sj@kernel.org>
DAMON_STAT is assuming DAMON is ready to use in module_init time, and
uses its own hack to see if it is the time. Use damon_initialized(),
which is a way for seeing if DAMON is ready to be used that is more
reliable and better to maintain instead of the hack.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/stat.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/mm/damon/stat.c b/mm/damon/stat.c
index 87bcd8866d4b..c4fbd8cfa5eb 100644
--- a/mm/damon/stat.c
+++ b/mm/damon/stat.c
@@ -214,8 +214,6 @@ static void damon_stat_stop(void)
damon_destroy_ctx(damon_stat_context);
}
-static bool damon_stat_init_called;
-
static int damon_stat_enabled_store(
const char *val, const struct kernel_param *kp)
{
@@ -229,7 +227,7 @@ static int damon_stat_enabled_store(
if (is_enabled == enabled)
return 0;
- if (!damon_stat_init_called)
+ if (!damon_initialized())
/*
* probably called from command line parsing (parse_args()).
* Cannot call damon_new_ctx(). Let damon_stat_init() handle.
@@ -250,12 +248,16 @@ static int __init damon_stat_init(void)
{
int err = 0;
- damon_stat_init_called = true;
+ if (!damon_initialized()) {
+ err = -ENOMEM;
+ goto out;
+ }
/* probably set via command line */
if (enabled)
err = damon_stat_start();
+out:
if (err && enabled)
enabled = false;
return err;
--
2.39.5
next prev parent reply other threads:[~2025-09-16 3:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 3:35 [PATCH 0/7] mm/damon: define and use DAMON initialization check function SeongJae Park
2025-09-16 3:35 ` [PATCH 1/7] mm/damon/core: implement damon_initialized() function SeongJae Park
2025-09-16 3:35 ` SeongJae Park [this message]
2025-09-16 3:35 ` [PATCH 3/7] mm/damon/reclaim: use damon_initialized() SeongJae Park
2025-09-16 3:35 ` [PATCH 4/7] mm/damon/lru_sort: " SeongJae Park
2025-09-16 3:35 ` [PATCH 5/7] samples/damon/wsse: " SeongJae Park
2025-09-16 3:35 ` [PATCH 6/7] samples/damon/prcl: " SeongJae Park
2025-09-16 3:35 ` [PATCH 7/7] samples/damon/mtier: " SeongJae Park
2025-09-16 4:33 ` [PATCH 0/7] mm/damon: define and use DAMON initialization check function Andrew Morton
2025-09-16 5:54 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916033511.116366-3-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox