linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org,
	usamaarif642@gmail.com, rientjes@google.com,
	roman.gushchin@linux.dev, harry.yoo@oracle.com,
	shakeel.butt@linux.dev, 00107082@163.com, pyyjason@gmail.com,
	pasha.tatashin@soleen.com, souravpanda@google.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output
Date: Mon, 15 Sep 2025 19:56:33 -0700	[thread overview]
Message-ID: <20250915195633.96236cecebd8777243a770bc@linux-foundation.org> (raw)
In-Reply-To: <CAJuCfpFQCgQLSrzfVjV+J4tkYbOx_W9v-kWmoo-rmh5hs9gEXA@mail.gmail.com>

On Mon, 15 Sep 2025 19:48:14 -0700 Suren Baghdasaryan <surenb@google.com> wrote:

> 
> > Perhaps we can tell people what accurate:no actually means.  It is a
> > rather disturbing thing to see!  How worried should our users be about
> > it?
> 
> Right. How about adding a section like this:
> 
> Supported markers in v2:
> accurate:no
>               Absolute values of the counters in this line are not
>               accurate because of the failure to allocate storage required
>               to track some of the allocations made at this location.
>               Deltas in these counters are accurate, therefore counters
>               can be used to track allocation size and count changes.
> 
> 
> If this looks good,

looks awesome ;)

> could you fold it into the existing patch or
> should I respin?

A little fixlet would be preferred (by me, at least).


  reply	other threads:[~2025-09-16  2:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 23:02 Suren Baghdasaryan
2025-09-15 23:05 ` Suren Baghdasaryan
2025-09-16  0:11 ` Andrew Morton
2025-09-16  2:48   ` Suren Baghdasaryan
2025-09-16  2:56     ` Andrew Morton [this message]
2025-09-16  3:34       ` Suren Baghdasaryan
2025-09-16  4:21         ` Andrew Morton
2025-09-16  4:39           ` Suren Baghdasaryan
2025-09-16 16:02             ` Suren Baghdasaryan
2025-09-16 12:57 ` Vlastimil Babka
2025-09-16 15:51   ` Suren Baghdasaryan
2025-09-16 21:11     ` Usama Arif
2025-09-16 21:46       ` Suren Baghdasaryan
2025-09-16 21:52         ` Usama Arif
2025-09-16 22:26           ` Suren Baghdasaryan
2025-09-16 22:27             ` Suren Baghdasaryan
2025-09-17 21:09               ` Usama Arif
2025-09-17 23:04                 ` Suren Baghdasaryan
2025-09-17  7:38             ` Vlastimil Babka
2025-09-17 23:02               ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250915195633.96236cecebd8777243a770bc@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=00107082@163.com \
    --cc=hannes@cmpxchg.org \
    --cc=harry.yoo@oracle.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pyyjason@gmail.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=souravpanda@google.com \
    --cc=surenb@google.com \
    --cc=usamaarif642@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox