linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>, Baoquan He <bhe@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Uladzislau Rezki <urezki@gmail.com>
Subject: [PATCH v2 04/10] mm/vmalloc: Avoid cond_resched() when blocking is not permitted
Date: Mon, 15 Sep 2025 15:40:34 +0200	[thread overview]
Message-ID: <20250915134041.151462-5-urezki@gmail.com> (raw)
In-Reply-To: <20250915134041.151462-1-urezki@gmail.com>

vm_area_alloc_pages() contains the only voluntary reschedule points
along vmalloc() allocation path. They are needed to ensure forward
progress on PREEMPT_NONE kernels under contention for vmap metadata
(e.g. alloc_vmap_area()).

However, yielding should only be done if the given GFP flags allow
blocking. This patch avoids calling cond_resched() when allocation
context is non-blocking(GFP_ATOMIC, GFP_NOWAIT).

Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
 mm/vmalloc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 49a0f81930a8..b77e8be75f10 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3633,7 +3633,9 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
 							pages + nr_allocated);
 
 			nr_allocated += nr;
-			cond_resched();
+
+			if (gfpflags_allow_blocking(gfp))
+				cond_resched();
 
 			/*
 			 * If zero or pages were obtained partly,
@@ -3675,7 +3677,9 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
 		for (i = 0; i < (1U << order); i++)
 			pages[nr_allocated + i] = page + i;
 
-		cond_resched();
+		if (gfpflags_allow_blocking(gfp))
+			cond_resched();
+
 		nr_allocated += 1U << order;
 	}
 
-- 
2.47.3



  parent reply	other threads:[~2025-09-15 13:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 13:40 [PATCH v2 00/10] __vmalloc() and no-block support(v2) Uladzislau Rezki (Sony)
2025-09-15 13:40 ` [PATCH v2 01/10] lib/test_vmalloc: add no_block_alloc_test case Uladzislau Rezki (Sony)
2025-09-15 13:40 ` [PATCH v2 02/10] lib/test_vmalloc: Remove xfail condition check Uladzislau Rezki (Sony)
2025-09-15 13:40 ` [PATCH v2 03/10] mm/vmalloc: Support non-blocking GFP flags in alloc_vmap_area() Uladzislau Rezki (Sony)
2025-09-18  2:56   ` Baoquan He
2025-09-15 13:40 ` Uladzislau Rezki (Sony) [this message]
2025-09-15 17:11   ` [PATCH v2 04/10] mm/vmalloc: Avoid cond_resched() when blocking is not permitted Michal Hocko
2025-09-16 15:28     ` Uladzislau Rezki
2025-09-16 18:08       ` Michal Hocko
2025-09-17  5:22         ` Uladzislau Rezki
2025-09-18  2:57   ` Baoquan He
2025-09-15 13:40 ` [PATCH v2 05/10] mm/vmalloc: Defer freeing partly initialized vm_struct Uladzislau Rezki (Sony)
2025-09-18  2:59   ` Baoquan He
2025-09-15 13:40 ` [PATCH v2 06/10] mm/vmalloc: Handle non-blocking GFP in __vmalloc_area_node() Uladzislau Rezki (Sony)
2025-09-18  3:01   ` Baoquan He
2025-09-15 13:40 ` [PATCH v2 07/10] mm/kasan: Support non-blocking GFP in kasan_populate_vmalloc() Uladzislau Rezki (Sony)
2025-09-18  3:02   ` Baoquan He
2025-09-18 14:56   ` Andrey Ryabinin
2025-09-15 13:40 ` [PATCH v2 08/10] kmsan: Remove hard-coded GFP_KERNEL flags Uladzislau Rezki (Sony)
2025-09-15 13:40 ` [PATCH v2 09/10] mm: Skip might_alloc() warnings when PF_MEMALLOC is set Uladzislau Rezki (Sony)
2025-09-15 17:16   ` Michal Hocko
2025-09-16 15:23     ` Uladzislau Rezki
2025-09-15 13:40 ` [PATCH v2 10/10] mm/vmalloc: Update __vmalloc_node_range() documentation Uladzislau Rezki (Sony)
2025-09-15 17:13   ` Michal Hocko
2025-09-16 15:34     ` Uladzislau Rezki
2025-09-16  0:34   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250915134041.151462-5-urezki@gmail.com \
    --to=urezki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox