From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACBDCCAC597 for ; Mon, 15 Sep 2025 12:16:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17ED08E000D; Mon, 15 Sep 2025 08:16:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 157BE8E0001; Mon, 15 Sep 2025 08:16:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01F0D8E000D; Mon, 15 Sep 2025 08:16:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E14798E0001 for ; Mon, 15 Sep 2025 08:16:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9545214064C for ; Mon, 15 Sep 2025 12:16:25 +0000 (UTC) X-FDA: 83891382330.01.975D66C Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010013.outbound.protection.outlook.com [52.101.193.13]) by imf09.hostedemail.com (Postfix) with ESMTP id DF07D140010 for ; Mon, 15 Sep 2025 12:16:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=rR1yMTm4; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of jgg@nvidia.com designates 52.101.193.13 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757938583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9L0MevsaZl4URnpEE5ruNJ+WATqAH6AxktDl4S6aji4=; b=Y72YT8YCSLlVtEt+M8ddEs5/4c7WgUbcaODDtLEiH/cQhGb2foyk8JmBLs6oquccflj+lh FaywHp38H3qUU2mL/SIwB0wvKbnshUeSisfLhFfxSDzXlA5o0kBQotQm3hgFLF1UL5Rrbu E3+XTdnSmRjdUby5GwPvXy7mgJhrQVY= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1757938583; a=rsa-sha256; cv=pass; b=qeCr+9jr6atyROEz2XVcv2zNbl6jNiGyvh+0B8Y0OW7wr4oOeC9VZGA6NuAYA4XJhpGABm Su0VjDFQ3cQBronr11OEHmm4HRBTWqzYrKTYuMClL3S/lNxX/HItB7oJG3stTHThy//MZo HFvr4vYT+sC0wskgGUtyyGvZ9j9peWc= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=rR1yMTm4; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of jgg@nvidia.com designates 52.101.193.13 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v16KWpkY3ImVT7qges0lHR6lT7j5DpTGpknezkG5+BUVFtHh/ACwDMCuFCks0M1M4uI7dsgQurF1BHur3WYN9tJ67vKFtTG1NNa8TDFOQiBFZEhsO1yP9g+UiSfzvmFXoFYCtFa3hTrxdwFu8NUtPGY3O3uAY1VGxogBpxnxX462w3vCTTUYLrnAZiIU5iYOiRMaDAf8GfHQxAiVBmoK+t4RoT3E6h4mRzcn4m6g9RMHc4e1+5/z7uQz1KLfq4chgtUiM5wYpaap+uV/veh+KAeSleyArSyDLk9K6SOLyoEXkUKTWWj/C7RsZy5bgEVMRHXQopGwwcqiiGaBeSq6UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9L0MevsaZl4URnpEE5ruNJ+WATqAH6AxktDl4S6aji4=; b=RX7ZYWqO9jflUsBRexVAGfbTW97vj9htFuwgmCTO2W9zsaJDqY4wWOHkBiqJ8D0r2IYFMNO06BZdrYBQqPnC1usoG7AN44CR4NtmheaWHXAflDsvmIGVwPpdq8JYaoK28Au37yrAJU81e3FHs0ZIYvCD3MivUNwtoKPdPU33/XCWTtatoRdLJDi0+6w9CE+Ueo0wf1NFberNDWBqkRKliwCwbxGM8iFkvq6WyxFvRK5clvyWMmfhLcyN/ChNxvxuV/eFGk3S2/KlB+mW3D1QqDf330i5m3X0UhBPG/kv921plmP7m6QVRaVcPbj5REAmgOnC6a8+X1gjiA4dxsmTNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9L0MevsaZl4URnpEE5ruNJ+WATqAH6AxktDl4S6aji4=; b=rR1yMTm4pit+c8u7H0D0Y9kdyhDqnW2nq695VD0nYBlSZZHp1GChE3zcAfkMrBFIhGXKppoqFSWMXnigw2BlJ2Gse+Hao02erT3c3oJfejyyH+phk2CEOZ5/16sSTCq4sHRsSGjFXq/YSC6vGG9nvtfHGYgZPPpP5fWEZmMN5hQLkHtwLQPtFCWGGDuWxMC5ta1hHeYdR4x9D3i+fwcBKn7lU0kfWLi6K2aclN6yzz5KOTL0UQ3dYmXdC73z2UZpZF7kwuj9mhfdj2OW0dcgCc9vXkDVON3umMaDOv0cjVwjPtrhKjxIiRtpk10SqJjZlEiMbMJLgM19pZIBH7uRDg== Received: from PH7PR12MB5757.namprd12.prod.outlook.com (2603:10b6:510:1d0::13) by DS0PR12MB6632.namprd12.prod.outlook.com (2603:10b6:8:d0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Mon, 15 Sep 2025 12:16:19 +0000 Received: from PH7PR12MB5757.namprd12.prod.outlook.com ([fe80::f012:300c:6bf4:7632]) by PH7PR12MB5757.namprd12.prod.outlook.com ([fe80::f012:300c:6bf4:7632%2]) with mapi id 15.20.9115.020; Mon, 15 Sep 2025 12:16:19 +0000 Date: Mon, 15 Sep 2025 09:16:17 -0300 From: Jason Gunthorpe To: Lorenzo Stoakes Cc: Andrew Morton , Jonathan Corbet , Matthew Wilcox , Guo Ren , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Nicolas Pitre , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Baoquan He , Vivek Goyal , Dave Young , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Uladzislau Rezki , Dmitry Vyukov , Andrey Konovalov , Jann Horn , Pedro Falcato , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, kexec@lists.infradead.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v2 16/16] kcov: update kcov to use mmap_prepare Message-ID: <20250915121617.GD1024672@nvidia.com> References: <5b1ab8ef7065093884fc9af15364b48c0a02599a.1757534913.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b1ab8ef7065093884fc9af15364b48c0a02599a.1757534913.git.lorenzo.stoakes@oracle.com> X-ClientProxiedBy: YT4P288CA0046.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d3::28) To PH7PR12MB5757.namprd12.prod.outlook.com (2603:10b6:510:1d0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB5757:EE_|DS0PR12MB6632:EE_ X-MS-Office365-Filtering-Correlation-Id: f35a159a-93dd-4f31-8c8e-08ddf451ad2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FJ+GMy316Ah1W2PRNL2uK0E4d8rheS0eMVrJO4fwtwoJVvgRBslOImN624yP?= =?us-ascii?Q?qn/ODRZ+eoKmIUc/H8K5IVkhwAv3B1GndIBDMGBA/M2ORQkApBPyju9k776E?= =?us-ascii?Q?sPmiT8Cn2OcosjlMmtT9CiugaKagkVWjraWs+WUSjLf40pRrnIiJaH7qmUUR?= =?us-ascii?Q?D1YnJmUzM5/sKkSFbA1oYJt6UpwBYpLXAh7JD4gd+nPqoh0Vt0OgQTwCTQO2?= =?us-ascii?Q?pJ3w1DVazyydFZFl2tpsflpn9qZSwyWfRqxaWDU6INzU2R1RQ/zQ9IqtCXrL?= =?us-ascii?Q?21QRCOZLg0nI1FMwtK5xxFuABD5QHz/UynorLrHMx7g4C8/wc0jonjscEwQc?= =?us-ascii?Q?Ez2cXZJNjyMH6cTU/WmvIXxEauwrLLPIRRI1x63OAGB7zhXimQTj4gAFXNA+?= =?us-ascii?Q?dXFX49ljNP4IDBh8MqI6sW/YS7RBi32O8IW/z4aVia+Z6/MbA116VOid25qn?= =?us-ascii?Q?WWnDm4WwNUWVDxOyo+IL8yxp0DpA26BXsIto5Wf7MVZHArw/FOldfb0/BF20?= =?us-ascii?Q?+khK0J36F+nUIPZ4n/o0rDfRtrj59JU/BpXEN7BYjOE0EIJ5NANghpy1oA1n?= =?us-ascii?Q?T7esIJ8gzTXWF2zhIrpWsfFz7DUwIqsen6rqyYlka6JvljAQnnexWrZKidKM?= =?us-ascii?Q?bwsaRJ7DyYC7hR/hQ7c5MyqzErxGM7td9AEPTf5tN9BvZn6HsnzkLjqQxBfJ?= =?us-ascii?Q?rCFMelL0ZAu/0MVguJRRjU5fo91scmSc/i5ADIb/BHc2D3TstjxcAU0eFYqA?= =?us-ascii?Q?OSuiBwFrSe/Ow8MggoPW0gV+rPbhvKgDO6ZIOoGRramKN1i8sw6Mo/oAqqie?= =?us-ascii?Q?7hhUPSfe+KKWu6k600DNeEH4wwqglRs895mc9zS/Vf05VNajpIWCDOATw4LM?= =?us-ascii?Q?RMhP34Xd1TkhWfkQk6V5vsPaqjpndfnGlqinJ4M0bSXcIVPqBcpW68RyI0sr?= =?us-ascii?Q?IrSopJQFXWmhOOcXAC4WRJ6xO5Nsmymbvg1oHipT9KZlwozBnz+4ikzmUPXh?= =?us-ascii?Q?ansdYgwY+CUy7+Gn6dLYTLypjn7fyYc+BP96q3aseS1YpHn9+WmrR2EYz0Xs?= =?us-ascii?Q?p2kVhLx3mvujLNXztcyF9ouXiy8NJ+HWuASAC81a2N4S0JzuKDloN8BG1wxW?= =?us-ascii?Q?efm1gDyw4tAFPYBm75o834G3X60PnZd8nDPeD/uQaP6SIbupr2e/0zDfzRlN?= =?us-ascii?Q?9t6RLcgKXLFpbeUfwtjAWQjPN380JM0SoN92vky3WFaZCfq5Xuq6av/PJmD1?= =?us-ascii?Q?Ka9tulrWkP71qQ1y3QKWGOXgF62unORpW7h42NyJXpIccfEQAlJzSPsaXvw9?= =?us-ascii?Q?LJJovAtdN7zusj39sjsmd5cA2x43S3LxsWC59F16Gf2k3gXNmPOqltU/08QF?= =?us-ascii?Q?5gMJ4OxrVFtRxyLfoQ0XhvfAA169q4zXhcdoaBV4Er0MNKjj5LDZQkIHkTtW?= =?us-ascii?Q?mOej1NYler4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB5757.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WgeUIJi5cY2sk5lj8fMjb+H+kNFLtDA7lYE2X0J/GN5d5Ob0yf+l1+EZdKBo?= =?us-ascii?Q?+RhTJ29Te8+tf3x4tbPbdBM7rBkIiTVK4ix4yblQnvO6G+L9zbhliXopHrd2?= =?us-ascii?Q?NFFkFVVeYNMQA/UB1NmQSJzE4NFPmO9dhzdjYo5IwmCpkQ1vYtDBNo8y9JB5?= =?us-ascii?Q?LOKYnrViMUuiiVGlAoQ5ivfDXViVrxsE/Cx3oreqaoaiqNjdkcs0T2F2hj+x?= =?us-ascii?Q?u933Qdle6HxY8QXI/Clx6OQRLFaU4w7qL+DSCETS3JD+KD3v+8ObP0hiJ7tz?= =?us-ascii?Q?QHfprJZyWKoC1gBKoWFQFhHnJk7nUqnHQEhohe8kFWr+ieOCFiNO/J5nh5zn?= =?us-ascii?Q?c14VmrL3LInJ3Sw3wb1CFw9gUjBFRsCKqYeP3Kpuyfuom2ncO0PbAorjCpKN?= =?us-ascii?Q?VQqgeWK1PAw69K3bCLplbimtl2qhCcyRKcoLgcCQOgHVMQTZv3hXChl3GNhP?= =?us-ascii?Q?jPkrow1WVCFc9ElpIqaXejhoIsPSsBG28of1LCkmM9OY912wgnVg93ycxa5h?= =?us-ascii?Q?kXqsYL7wDrPgEoJ8R2xBFCA6+KsqwVrXQSHOsROsW8jWAe+3BNiQ5/f1fIwf?= =?us-ascii?Q?LDeYaWNiMjyhiEW1EguQQABUcOMsP0fbe8yYCScBSzVNix1JMT2w4exz58tO?= =?us-ascii?Q?ngtwUsSXRXmL88OqDha1EivU7oyhVgXmjrndhSvMiJOFN4OiPswEX/1lFEwS?= =?us-ascii?Q?ZOr2gthO5JJnLqYuN+qkGt0U+/Eka3+KKoDKtSk1KtUD2k0zHq89sSOT3dHW?= =?us-ascii?Q?JB50Ku8O8S6zPmNR6p+xvGQYnokn6ncqaGJ/FDXyQ6hhq1aWm4UWLJ2oU4cm?= =?us-ascii?Q?tS/g2sM8/YfeNVWtfv/vMtfNhKPCdh0p1bpnCJgOiTrDeX3y+gxqCFzSQYtS?= =?us-ascii?Q?mOtawXaV2y9IbYMwRareJ/fdhJRFOD7ZC1lAGh+oFuTlpIwgDyEOj622oqF+?= =?us-ascii?Q?/F8J2R+GwDE7cK+ksSQEjWTwJdjqQZ4RDFwRzVXVo90323HTq4HHcuQ0habU?= =?us-ascii?Q?zguwnBRC5Hb8K0r04OcGoJ6PHm8MlEvb2TT5QhFfT2+aNsKYNVqLFqL899gp?= =?us-ascii?Q?NWwA8gjiGgtYpUFUu+Cg0ALcvic2lgHyMFdayXTQ98cynm9SmVrMD4qZu1+P?= =?us-ascii?Q?mIZBVI1Oa+nFyuriJnScudW8JM4zxi6T8rIlVctAoVFaV1N3vx+Km/9AkBYd?= =?us-ascii?Q?+PKBlXnYdcnqP9V0ww5eldolEmyLHbuCpCTVaMxS1aQ3Le6kHCrwvO6hzw5B?= =?us-ascii?Q?DXtVAV4nHiUarz0VQ2pwY7m8GDWFtI8itNriN9vFG1n+y08VxRsgJX9oA33C?= =?us-ascii?Q?4HJvlVsYd8qxMXz9jufApjap6Nxq1MqT3xpqyP4EtsL6TA0F5apODmOPnVcR?= =?us-ascii?Q?yS6NvJ6OMaq31dh9bsPKmxY3HHiC/cHFdE1hUwSJaB4Nyy+k43r9GSS1nK1m?= =?us-ascii?Q?5EIljg2pSt3bKjfdKoJFbiT/eAoy+/zrMIKEScHw6y+EOezTjqB2Xt2o4Oxd?= =?us-ascii?Q?IvZnZoM0NAtT81lqejPsR1wZiLQIryf6qKQ9n+qWu9RFNoBFrCApj0YGSwVG?= =?us-ascii?Q?tDjxwenHqv+3Ncshhmo=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f35a159a-93dd-4f31-8c8e-08ddf451ad2a X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5757.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2025 12:16:19.3375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DEkAUuneTEE997o8Ffh1wmwK0ptrvvqE/Q+wl2h3x6DZFuitcS2eewWiuv5vGq3l X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6632 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DF07D140010 X-Stat-Signature: ta6qbmh7a5ih5mtcqpwy6wi461a8aped X-Rspam-User: X-HE-Tag: 1757938582-100441 X-HE-Meta: U2FsdGVkX19giiYNz60kqKMfT6Df0X902IuwGrgFR2wsMWnl9wkre+8FmNkbGqMIlvvc6qg/O+HJaYoCzu+cJ26SOxc44pYk59QD82z9VORIBZUtuF199yiFWsiUqIL95u/ySQjL7mfJjg+zmespV/oEj4aigqLdczAJUPWbdkWzOkLki9Tr+s1Cf/rC3VY0FOjPgGhhvmRUYmq0FD7/UBCU2ZqegUSjwxB9EdwlM6YqWnTtS0UEeEgW5V7KzX/pSWAnPdmz8tLEKspWdG0iuGHjqcYFvgsrSbrA4m/5E/nHghiw+R15zeE9Sg76tWAW7E8KaflvLh7j7hTqMIv6u/HnKFFDSPImaiPnFLMDmW5+AqysdY1Z3xpf7p2Lae1AKdr5z0eSYN4Xj6ch6ZrE3nQLmNEZfD+LfqWKlmBUiNUu5SxPNxBPgDBfii5G9dwCp9kyNthi9wqJ8fehqNsh6cuQclpuThwyAbFasM3AnBWCK2BYvMKBRYRKcPTp2uSly6haKkmxI8/QIUajkPlgCdS5a21Tg//OdEj3zgoQiMXK6Q1sLBiSN7WI4EEa1LZFoVBLKdVR+BuUoUGo5KfpTFKS0vE3oE7H/BUToH6UzqZaTahD0UDc7UmB0Gi/piPVfz/bxkYi8JKWDoPTM2QEUtsmqMA9ZMWb20lQGDw3NdH8Bzs8C9V/Xc0HOlzoSQTpNFOVBT/+gpUV9Rn+8PsBwMtjJ8SOMSaTgtYugMuDdx3q00hbeuPys1xAXqSk0tdkRRMUgv61Dv3vNTeLuwQksYcidF4a5rSs5v6TWkGbJWcmoEGJIxLELu902esJ4oFnOLXBF0tp5LP0+hmhSULJyJE5nPUt9PZ26B6m92tvhyId514fXJ2YP88smKHc2QIC1P8aJLPklRWvnstWO3ir1U24zroeG4rXQQJxxWDW9eEMF8h11XmZ4WQATyx8l0ptJ9qZao/rU4bqlm+PNCq Uvn/jgq9 kI6ORpSCjdKDR3+nOW4kWlHDFsznB3rsYcgEr9RFWgJcNDtPAzMHj7v7tWu9PGoS8YvSVVo9N88Btt/nW1eVVJcmlC5C6qwlnu4Mct+5O+HDRNNqtAGnkoVwq7Im+n3+oHLj09Qgtjc1wG7sNxwJb+/QSmE2F3id/86JEuTdKn6KAUtUse+sYs+u+nkQDxc1EZXfVubbi5J68JAvkEFtiSHdpJWVI/I/S9VDpGi/A1MK+Na+KtbmQDDMBMmHcfE4JzOCpmXJu2QiS0pP/6zYYpbd0XwrvgUXJGZxHlH7w5kW3UwwuaYyRQxXA9EU7dFuM6VoOjL2dFYWcqqGijphYmmfyLC1uc8CyHAhUoRnnI5OF70oHCx2zg0mwV9je6c/cGUjcft1NAik4HQgiiKDkf1FNhWrUXAOUkfvxyXEnH5WxoC9tCf5n+TY2pXzhOuII8fhHd0YkFgl7SY7AYKtOFGVpxlW/oV6AG6uxpAWK0RrkxIXoVa1QIeCKGZhTFzvgrLHMmrNjkp3gCoEGy0UVDK2j57FHxqlbp7hsiexlfqWz4MTL8mbFGBUIiMpJzGcUncz2UEyLnu1jza4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 10, 2025 at 09:22:11PM +0100, Lorenzo Stoakes wrote: > +static int kcov_mmap_prepare(struct vm_area_desc *desc) > { > int res = 0; > - struct kcov *kcov = vma->vm_file->private_data; > - unsigned long size, off; > - struct page *page; > + struct kcov *kcov = desc->file->private_data; > + unsigned long size, nr_pages, i; > + struct page **pages; > unsigned long flags; > > spin_lock_irqsave(&kcov->lock, flags); > size = kcov->size * sizeof(unsigned long); > - if (kcov->area == NULL || vma->vm_pgoff != 0 || > - vma->vm_end - vma->vm_start != size) { > + if (kcov->area == NULL || desc->pgoff != 0 || > + vma_desc_size(desc) != size) { IMHO these range checks should be cleaned up into a helper: /* Returns true if the VMA falls within starting_pgoff to starting_pgoff + ROUND_DOWN(length_bytes, PAGE_SIZE)) Is careful to avoid any arithmetic overflow. */ vma_desc_check_range(desc, starting_pgoff=0, length_bytes=size); > + desc->vm_flags |= VM_DONTEXPAND; > + nr_pages = size >> PAGE_SHIFT; > + > + pages = mmap_action_mixedmap_pages(&desc->action, desc->start, > + nr_pages); > + if (!pages) > + return -ENOMEM; > + > + for (i = 0; i < nr_pages; i++) > + pages[i] = vmalloc_to_page(kcov->area + i * PAGE_SIZE); This is not a mixed map. All the memory comes from vmalloc_user() which makes them normal struct pages with refcounts. If anything the action should be called mmap_action_vmalloc_user() to match how the memory was allocated instead of open coding something. Jason