From: Wei Yang <richard.weiyang@gmail.com>
To: Balbir Singh <balbirs@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
damon@lists.linux.dev, dri-devel@lists.freedesktop.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@redhat.com>, "Zi Yan" <ziy@nvidia.com>,
"Joshua Hahn" <joshua.hahnjy@gmail.com>,
"Rakie Kim" <rakie.kim@sk.com>,
"Byungchul Park" <byungchul@sk.com>,
"Gregory Price" <gourry@gourry.net>,
"Ying Huang" <ying.huang@linux.alibaba.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Oscar Salvador" <osalvador@suse.de>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Nico Pache" <npache@redhat.com>,
"Ryan Roberts" <ryan.roberts@arm.com>,
"Dev Jain" <dev.jain@arm.com>, "Barry Song" <baohua@kernel.org>,
"Lyude Paul" <lyude@redhat.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Mika Penttilä" <mpenttil@redhat.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Francois Dugast" <francois.dugast@intel.com>
Subject: Re: [v4 06/15] mm/migrate_device: implement THP migration of zone device pages
Date: Thu, 11 Sep 2025 08:04:04 +0000 [thread overview]
Message-ID: <20250911080404.r6vqlhyi7qyjutij@master> (raw)
In-Reply-To: <20250903011900.3657435-7-balbirs@nvidia.com>
On Wed, Sep 03, 2025 at 11:18:51AM +1000, Balbir Singh wrote:
[...]
>@@ -836,15 +1107,47 @@ static void __migrate_device_pages(unsigned long *src_pfns,
> migrate->pgmap_owner);
> mmu_notifier_invalidate_range_start(&range);
> }
>- migrate_vma_insert_page(migrate, addr, newpage,
>+
>+ if ((src_pfns[i] & MIGRATE_PFN_COMPOUND) &&
>+ (!(dst_pfns[i] & MIGRATE_PFN_COMPOUND))) {
>+ nr = HPAGE_PMD_NR;
This one trigger BUILD_BUG() if !PGTABLE_HAS_HUGE_LEAVES.
>+ src_pfns[i] &= ~MIGRATE_PFN_COMPOUND;
>+ src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
>+ goto next;
>+ }
>+
>+ migrate_vma_insert_page(migrate, addr, &dst_pfns[i],
> &src_pfns[i]);
>- continue;
>+ goto next;
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2025-09-11 8:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 1:18 [v4 00/15] mm: support device-private THP Balbir Singh
2025-09-03 1:18 ` [v4 01/15] mm/zone_device: support large zone device private folios Balbir Singh
2025-09-11 11:43 ` David Hildenbrand
2025-09-03 1:18 ` [v4 02/15] mm/huge_memory: add device-private THP support to PMD operations Balbir Singh
2025-09-03 1:18 ` [v4 03/15] mm/rmap: extend rmap and migration support device-private entries Balbir Singh
2025-09-03 1:18 ` [v4 04/15] mm/huge_memory: implement device-private THP splitting Balbir Singh
2025-09-03 1:18 ` [v4 05/15] mm/migrate_device: handle partially mapped folios during collection Balbir Singh
2025-09-03 4:40 ` Mika Penttilä
2025-09-03 6:05 ` Balbir Singh
2025-09-03 8:26 ` Mika Penttilä
2025-09-04 9:37 ` kernel test robot
2025-09-03 1:18 ` [v4 06/15] mm/migrate_device: implement THP migration of zone device pages Balbir Singh
2025-09-11 8:04 ` Wei Yang [this message]
2025-09-11 11:11 ` Mika Penttilä
2025-09-03 1:18 ` [v4 07/15] mm/memory/fault: add THP fault handling for zone device private pages Balbir Singh
2025-09-03 1:18 ` [v4 08/15] lib/test_hmm: add zone device private THP test infrastructure Balbir Singh
2025-09-03 1:18 ` [v4 09/15] mm/memremap: add driver callback support for folio splitting Balbir Singh
2025-09-03 1:18 ` [v4 10/15] mm/migrate_device: add THP splitting during migration Balbir Singh
2025-09-03 1:18 ` [v4 11/15] lib/test_hmm: add large page allocation failure testing Balbir Singh
2025-09-03 1:18 ` [v4 12/15] selftests/mm/hmm-tests: new tests for zone device THP migration Balbir Singh
2025-09-03 1:18 ` [v4 13/15] selftests/mm/hmm-tests: partial unmap, mremap and anon_write tests Balbir Singh
2025-09-03 1:18 ` [v4 14/15] selftests/mm/hmm-tests: new throughput tests including THP Balbir Singh
2025-09-03 1:19 ` [v4 15/15] gpu/drm/nouveau: enable THP support for GPU memory migration Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911080404.r6vqlhyi7qyjutij@master \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=byungchul@sk.com \
--cc=dakr@kernel.org \
--cc=damon@lists.linux.dev \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=francois.dugast@intel.com \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lyude@redhat.com \
--cc=matthew.brost@intel.com \
--cc=mpenttil@redhat.com \
--cc=npache@redhat.com \
--cc=osalvador@suse.de \
--cc=rakie.kim@sk.com \
--cc=rcampbell@nvidia.com \
--cc=ryan.roberts@arm.com \
--cc=simona@ffwll.ch \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox