From: Andrew Morton <akpm@linux-foundation.org>
To: Balbir Singh <balbirs@nvidia.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
oe-kbuild@lists.linux.dev, lkp@intel.com,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [akpm-mm:mm-new 398/411] mm/huge_memory.c:3069 __split_huge_pmd_locked() error: uninitialized symbol 'write'.
Date: Wed, 10 Sep 2025 17:57:14 -0700 [thread overview]
Message-ID: <20250910175714.4203dba33afea5516761bb2a@linux-foundation.org> (raw)
In-Reply-To: <88f160fb-0f84-49e2-9139-1fba1a21428e@nvidia.com>
On Thu, 11 Sep 2025 07:54:20 +1000 Balbir Singh <balbirs@nvidia.com> wrote:
> > smatch warnings:
> > mm/huge_memory.c:3069 __split_huge_pmd_locked() error: uninitialized symbol 'write'.
> > mm/huge_memory.c:3078 __split_huge_pmd_locked() error: uninitialized symbol 'young'.
> >
> > vim +/write +3069 mm/huge_memory.c
> >
>
> If the entry is not present, it is a migration or device private entry, so write is
> set, I understand that smatch is complaining about it falling through the paths.
>
> If freeze is true for a device private migration entry, young needs to be initialized
> to false.
>
> Andrew I can send out a patch to fix it or I can wait to gather more feedback
> and do a v6?
I think a little fixup would be good - it's nice to keep track of these
things as they pop up.
Is a v6 expected? I'm not seeing anything yet which would necessitate
that.
prev parent reply other threads:[~2025-09-11 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 11:52 Dan Carpenter
2025-09-10 21:54 ` Balbir Singh
2025-09-11 0:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910175714.4203dba33afea5516761bb2a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbirs@nvidia.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox