From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Harry Yoo <harry.yoo@oracle.com>,
linux-mm@kvack.org
Subject: [PATCH v2 12/22] slab: Remove folio references from kvfree_rcu_cb()
Date: Wed, 10 Sep 2025 12:54:54 +0100 [thread overview]
Message-ID: <20250910115507.1991829-13-willy@infradead.org> (raw)
In-Reply-To: <20250910115507.1991829-1-willy@infradead.org>
As with memcg_slab_post_charge(), we save a call to compound_head()
for large kmallocs. This has a slight change of behaviour in that
non-vmalloc, non-slab, non-kmalloc pointers will now cause a NULL
pointer dereference rather than a warning. We could add that back if
really needed.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
mm/slub.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 68a013411ff7..547ef6ef4373 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -6252,7 +6252,7 @@ static void free_large_kmalloc(struct page *page, void *object)
void kvfree_rcu_cb(struct rcu_head *head)
{
void *obj = head;
- struct folio *folio;
+ struct page *page;
struct slab *slab;
struct kmem_cache *s;
void *slab_addr;
@@ -6263,20 +6263,20 @@ void kvfree_rcu_cb(struct rcu_head *head)
return;
}
- folio = virt_to_folio(obj);
- if (!folio_test_slab(folio)) {
+ page = virt_to_page(obj);
+ if (PageLargeKmalloc(page)) {
/*
* rcu_head offset can be only less than page size so no need to
- * consider folio order
+ * consider allocation order
*/
obj = (void *) PAGE_ALIGN_DOWN((unsigned long)obj);
- free_large_kmalloc(&folio->page, obj);
+ free_large_kmalloc(page, obj);
return;
}
- slab = folio_slab(folio);
+ slab = page_slab(page);
s = slab->slab_cache;
- slab_addr = folio_address(folio);
+ slab_addr = slab_address(slab);
if (is_kfence_address(obj)) {
obj = kfence_object_start(obj);
--
2.47.2
next prev parent reply other threads:[~2025-09-10 11:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 11:54 [PATCH v2 00/22] Prepare slab for memdescs Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 01/22] slab: Remove unnecessary test from alloc_debug_processing() Matthew Wilcox (Oracle)
2025-09-10 22:19 ` Christoph Lameter (Ampere)
2025-09-10 11:54 ` [PATCH v2 02/22] slab: Remove unnecessary test from alloc_single_from_partial() Matthew Wilcox (Oracle)
2025-09-10 22:23 ` Christoph Lameter (Ampere)
2025-09-11 16:38 ` Vlastimil Babka
2025-09-10 11:54 ` [PATCH v2 03/22] slab: Remove dead code in check_slab() Matthew Wilcox (Oracle)
2025-09-10 22:27 ` Christoph Lameter (Ampere)
2025-09-10 11:54 ` [PATCH v2 04/22] slab: Remove dead code in free_consistency_checks() Matthew Wilcox (Oracle)
2025-09-10 22:30 ` Christoph Lameter (Ampere)
2025-09-11 15:29 ` Vlastimil Babka
2025-09-10 11:54 ` [PATCH v2 05/22] mm: Constify compound_order() and page_size() Matthew Wilcox (Oracle)
2025-09-10 14:01 ` Vlastimil Babka
2025-09-10 17:33 ` Christoph Lameter (Ampere)
2025-09-10 11:54 ` [PATCH v2 06/22] slab: Reimplement page_slab() Matthew Wilcox (Oracle)
2025-09-10 22:46 ` Christoph Lameter (Ampere)
2025-09-10 23:01 ` Matthew Wilcox
2025-09-10 23:14 ` Christoph Lameter (Ampere)
2025-09-11 7:10 ` Vlastimil Babka
2025-09-11 11:35 ` Matthew Wilcox
2025-09-10 11:54 ` [PATCH v2 07/22] slab: Remove folio references from __ksize() Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 08/22] slab: Remove folio references in memcg_slab_post_charge() Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 09/22] slab: Remove folio references in slab alloc/free Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 10/22] slab: Remove folio references from ___kmalloc_large_node() Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 11/22] slab: Remove folio references from free_large_kmalloc() Matthew Wilcox (Oracle)
2025-09-10 11:54 ` Matthew Wilcox (Oracle) [this message]
2025-09-10 11:54 ` [PATCH v2 13/22] slab: Remove folio references from kvfree() Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 14/22] slab: Remove folio references from __do_krealloc() Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 15/22] slab: Remove folio references from build_detached_freelist() Matthew Wilcox (Oracle)
2025-09-10 11:54 ` [PATCH v2 16/22] slab: Remove dead code from free_large_kmalloc() Matthew Wilcox (Oracle)
2025-09-10 22:45 ` Christoph Lameter (Ampere)
2025-09-10 11:54 ` [PATCH v2 17/22] slab: Remove folio references from kfree_rcu_sheaf() Matthew Wilcox (Oracle)
2025-09-10 11:55 ` [PATCH v2 18/22] usercopy: Remove folio references from check_heap_object() Matthew Wilcox (Oracle)
2025-09-10 11:55 ` [PATCH v2 19/22] memcg: Convert mem_cgroup_from_obj_folio() to mem_cgroup_from_obj_slab() Matthew Wilcox (Oracle)
2025-09-10 11:55 ` [PATCH v2 20/22] kasan: Remove references to folio in __kasan_mempool_poison_object() Matthew Wilcox (Oracle)
2025-09-10 11:55 ` [PATCH v2 21/22] slab: Remove references to folios from virt_to_slab() Matthew Wilcox (Oracle)
2025-09-10 11:55 ` [PATCH v2 22/22] mm: Remove redundant test in validate_page_before_insert() Matthew Wilcox (Oracle)
2025-09-10 14:02 ` Vlastimil Babka
2025-09-10 14:05 ` [PATCH v2 00/22] Prepare slab for memdescs Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910115507.1991829-13-willy@infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox