From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com,
mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org,
ziy@nvidia.com, wangkefeng.wang@huawei.com
Cc: linux-mm@kvack.org, Wei Yang <richard.weiyang@gmail.com>,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH] mm/compaction: fix low_pfn advance on isolating hugetlb
Date: Wed, 10 Sep 2025 09:22:40 +0000 [thread overview]
Message-ID: <20250910092240.3981-1-richard.weiyang@gmail.com> (raw)
Commit 56ae0bb349b4 ("mm: compaction: convert to use a folio in
isolate_migratepages_block()") converts api from page to folio. But the
low_pfn advance for hugetlb page seems wrong when low_pfn doesn't point
to head page.
Originally, if page is a hugetlb tail page, compound_nr() return 1,
which means low_pfn only advance one in next iteration. After the
change, low_pfn would advance more than the hugetlb range, since
folio_nr_pages() always return total number of the large page. This
results in skipping some range to isolate and then to migrate.
The worst case for alloc_contig is it does all the isolation and
migration, but finally find some range is still not isolated. And then
undo all the work and try a new range.
Advance low_pfn to the end of hugetlb.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Fixes: 56ae0bb349b4 ("mm: compaction: convert to use a folio in isolate_migratepages_block()")
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Oscar Salvador <osalvador@suse.de>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index bf021b31c7ec..1e8f8eca318c 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -989,7 +989,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
* Hugepage was successfully isolated and placed
* on the cc->migratepages list.
*/
- low_pfn += folio_nr_pages(folio) - 1;
+ low_pfn += folio_nr_pages(folio) - folio_page_idx(folio, page) - 1;
goto isolate_success_no_list;
}
--
2.34.1
next reply other threads:[~2025-09-10 9:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 9:22 Wei Yang [this message]
2025-09-11 1:25 ` Wei Yang
2025-09-11 1:35 ` Zi Yan
2025-09-11 1:38 ` Zi Yan
2025-09-11 1:50 ` Zi Yan
2025-09-11 3:34 ` Wei Yang
2025-09-11 6:30 ` Wei Yang
2025-09-11 16:28 ` Zi Yan
2025-09-12 0:28 ` Wei Yang
2025-09-12 1:13 ` Zi Yan
2025-09-12 6:00 ` Baolin Wang
2025-09-13 0:22 ` Zi Yan
2025-09-11 3:27 ` Wei Yang
2025-09-11 16:19 ` Zi Yan
2025-09-11 17:27 ` Vishal Moola (Oracle)
2025-09-12 1:07 ` Wei Yang
2025-09-12 1:29 ` Zi Yan
2025-09-12 17:22 ` Vishal Moola (Oracle)
2025-09-13 0:11 ` Wei Yang
2025-09-13 0:10 ` Wei Yang
2025-09-23 2:35 ` Andrew Morton
2025-09-23 2:41 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910092240.3981-1-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox