linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Yosry Ahmed <yosry.ahmed@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nhat Pham <nphamcs@gmail.com>,
	Chengming Zhou <zhouchengming@bytedance.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: zpdesc: minor naming and comment corrections
Date: Tue, 9 Sep 2025 16:11:13 +0100	[thread overview]
Message-ID: <20250909151113.GD1474@cmpxchg.org> (raw)
In-Reply-To: <mgt4ejjyz64ehnyskv24nzjllxxie4jvxb6i2dzlq43yev5dtu@sfltngevykts>

On Fri, Sep 05, 2025 at 07:05:22PM +0000, Yosry Ahmed wrote:
> On Fri, Aug 29, 2025 at 05:15:28PM +0100, Johannes Weiner wrote:
> > zpdesc is the page descriptor used by the zsmalloc backend allocator,
> > which in turn is used by zswap and zram. The zpool layer is gone.
> > 
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > ---
> 
> Why not rename zpdesc to zsdesc or zdesc while we're at it? It's a lot
> of noise but it's just this file and zsmalloc.c IIUC. Up to you.

I'm kind of fine with zpdesc and not sure the other names are this
much better to warrant the churn. So if you don't mind, I'd just leave
it alone for now.

> If it's just the comment changes I would squash it into the second
> patch, but not a big deal. Either way:
> 
> Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev>

Thanks for your review!


  reply	other threads:[~2025-09-09 15:11 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 16:15 [PATCH 0/3] mm: remove zpool Johannes Weiner
2025-08-29 16:15 ` [PATCH 1/3] mm: zswap: interact directly with zsmalloc Johannes Weiner
2025-09-05 18:53   ` Yosry Ahmed
2025-09-09 15:01     ` Johannes Weiner
2025-09-09 20:10       ` Yosry Ahmed
2025-09-10 13:42         ` Johannes Weiner
2025-09-11 14:30           ` Yosry Ahmed
2025-09-15 15:36             ` Johannes Weiner
2025-09-15 19:33               ` Yosry Ahmed
2025-08-29 16:15 ` [PATCH 2/3] mm: remove unused zpool layer Johannes Weiner
2025-08-29 19:07   ` SeongJae Park
2025-09-09 15:13     ` Johannes Weiner
2025-09-10  3:14       ` SeongJae Park
2025-09-05 18:58   ` Yosry Ahmed
2025-09-09 15:16     ` Johannes Weiner
2025-09-09 20:08       ` Yosry Ahmed
2025-09-09 20:09         ` Yosry Ahmed
2025-09-10 13:46           ` Johannes Weiner
2025-08-29 16:15 ` [PATCH 3/3] mm: zpdesc: minor naming and comment corrections Johannes Weiner
2025-09-05 19:05   ` Yosry Ahmed
2025-09-09 15:11     ` Johannes Weiner [this message]
2025-09-09 20:08       ` Yosry Ahmed
2025-09-04  9:33 ` [PATCH 0/3] mm: remove zpool Vitaly Wool
2025-09-04 10:13   ` Vlastimil Babka
2025-09-04 11:26     ` David Hildenbrand
2025-09-05  5:36       ` Vitaly Wool
2025-09-04 14:11     ` Vitaly Wool
2025-09-05  7:03       ` Vlastimil Babka
2025-09-05 18:02       ` Nhat Pham
2025-09-05 22:42         ` Vitaly Wool
2025-09-05 19:57       ` Yosry Ahmed
2025-09-06  5:25         ` Sergey Senozhatsky
2025-09-08 12:18           ` Sergey Senozhatsky
2025-09-09 20:12             ` Yosry Ahmed
2025-09-13 13:55               ` Vitaly Wool
2025-09-15 19:37                 ` Yosry Ahmed
2025-09-16 11:16                   ` Vitaly Wool
2025-09-16  3:29                 ` Sergey Senozhatsky
2025-09-04 23:47   ` Andrew Morton
2025-09-05  5:42     ` Vitaly Wool
2025-09-05 18:30       ` Andrew Morton
2025-09-05 22:20         ` Vitaly Wool
2025-09-04  9:51 ` Vitaly Wool
2025-09-05 17:52 ` Nhat Pham
2025-09-05 19:45   ` Yosry Ahmed
2025-09-05 21:35     ` Nhat Pham
2025-09-09 15:03       ` Johannes Weiner
2025-09-09 20:11         ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250909151113.GD1474@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=yosry.ahmed@linux.dev \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox