From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DA9CCAC581 for ; Mon, 8 Sep 2025 15:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C08E8E001C; Mon, 8 Sep 2025 11:16:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 796FF8E0001; Mon, 8 Sep 2025 11:16:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65E5D8E001C; Mon, 8 Sep 2025 11:16:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 53BAD8E0001 for ; Mon, 8 Sep 2025 11:16:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02FCBB6CE4 for ; Mon, 8 Sep 2025 15:16:52 +0000 (UTC) X-FDA: 83866435506.17.06F8C13 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57]) by imf28.hostedemail.com (Postfix) with ESMTP id 56C92C000B for ; Mon, 8 Sep 2025 15:16:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Npo5um5t; spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.223.57 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757344610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8j/RtS/D+IIx33VOOVem8cps3PsrXPIFRtoMeCJ3Q9w=; b=P2Fn0LIeQ+5BA5z0DRhEDJiYxGZutAcoRhF78/VXUr2YoTdoIh9WIv5UDcrKGrz9MWIAvb EpfX5dYwwjaoivvNwZ8lEOmqOwRaWCp3AHbiU635jdZNPc0ZVleUOvUEwb/PcO4qwR886L +OQ+grciH7qBokNspUMuBPJAAnruXb0= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Npo5um5t; spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.223.57 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1757344610; a=rsa-sha256; cv=pass; b=g5Lip83dML7+WihACOLgpkVHdc4pYtLtKzVdJTeL6alTddlNi3pp7EklV0Uv/NjCbGQYyk r7avL++v2WyqcLRvbnwKISebqjAvKGxF1VdWYuzMnF//McbhOfxK4UQH72NyURp+K0ewPh iIe/frlkUqxHki7VhzkuzrQszigf/bM= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=evDaJW2LZB0GdQBs6qDQ6zy5mLkGsKnGa9EHmoFBDNsBlUPKSy66+k/dQ53CFiTF3v1rhCu7DiASId9cGWA6f5FUiFYfI5QqcGaz45HvMiRsZ9mthC15U42dGgZiih4keozSOEyb27ml/1JBSpsEMS8JZhugRYtwCDKnarVRRbsBX9jZNYwfeiCtxLAjm8/AsWAK3JZb1xLGKOd5pb9gpEf5hpPyASTruEw5+aVtwiz1SvEQcFFrwgLvM+oQsBb/FB5Jo266YofpPXQWsrJ1y0ENznfbyH7tfL6+Tq91Xhb9V5ljy5REt46zOy2jIy5TKBCrAu/BpVhVuoVz+XystA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8j/RtS/D+IIx33VOOVem8cps3PsrXPIFRtoMeCJ3Q9w=; b=nqneYLwtfD4Xa9GqBrIalAVls8ucEuseXMwKLAd76wg5mT3RMdfbASlb9ib/d3AyWlxe6PdNQr+nBM4q+crd5q8JKtHpcJEOoxi9DqPJNpuuhwGSi38mwFzIjRH0NuvBN0+RK3UFx2t3u5AsXVahvduiQW1BGSxLro+an4zG1KBXqxf1c1ebjUAm42lRUCK7NxHTy8QBnRTOQmSQkRt2DYvFkPBq4k7IRns2TToEhcdatFArHjLh9t/pBmRy/dhiuTHQLXaUEOtLMJlYLyn40pOfFhQSSpRt2ardLie5o2OZBx0ROmpgFqxX6r6cXImgFucAXuwUcbpmD6HJVtPg/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8j/RtS/D+IIx33VOOVem8cps3PsrXPIFRtoMeCJ3Q9w=; b=Npo5um5t3z7qxhUPzGY7iujsPh0w7SUz8nx8i/blVlrxsOTXhIxBAlzXW9n/7JrluZiMLr+pv2+IWdfLEUppAMv2DQMft8dmWQIe1/pz1b/IQoGVyx9XQOwN6MkpyBXI0hhn0C2tV7CZCqCIWnu8k+7pVNheQZl9dsuIoSMqtRvpxyIJV+Z9pvm/nsukhyilF3uEV+RIPccfzk3GkwOnBqfSZhaXAqlsNAL0c6vSkzCvQF8Et1k3zh1CghvOBf28Kj6ihDXfILDM9ObG16Rn0hBu3/pfBMFK3kTSDKpDiss+tyfSS5ytZO3g+5immer00J1rMdbreUKwYEd/gkE2/w== Received: from PH7PR12MB5757.namprd12.prod.outlook.com (2603:10b6:510:1d0::13) by CY5PR12MB6647.namprd12.prod.outlook.com (2603:10b6:930:40::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Mon, 8 Sep 2025 15:16:40 +0000 Received: from PH7PR12MB5757.namprd12.prod.outlook.com ([fe80::f012:300c:6bf4:7632]) by PH7PR12MB5757.namprd12.prod.outlook.com ([fe80::f012:300c:6bf4:7632%2]) with mapi id 15.20.9094.017; Mon, 8 Sep 2025 15:16:40 +0000 Date: Mon, 8 Sep 2025 12:16:37 -0300 From: Jason Gunthorpe To: Lorenzo Stoakes Cc: Andrew Morton , Jonathan Corbet , Matthew Wilcox , Guo Ren , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Nicolas Pitre , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Baoquan He , Vivek Goyal , Dave Young , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Uladzislau Rezki , Dmitry Vyukov , Andrey Konovalov , Jann Horn , Pedro Falcato , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, kexec@lists.infradead.org, kasan-dev@googlegroups.com Subject: Re: [PATCH 03/16] mm: add vma_desc_size(), vma_desc_pages() helpers Message-ID: <20250908151637.GM616306@nvidia.com> References: <20250908125101.GX616306@nvidia.com> <20250908133224.GE616306@nvidia.com> <090675bd-cb18-4148-967b-52cca452e07b@lucifer.local> <20250908142011.GK616306@nvidia.com> <764d413a-43a3-4be2-99c4-616cd8cd3998@lucifer.local> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <764d413a-43a3-4be2-99c4-616cd8cd3998@lucifer.local> X-ClientProxiedBy: YT4PR01CA0426.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10b::10) To PH7PR12MB5757.namprd12.prod.outlook.com (2603:10b6:510:1d0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB5757:EE_|CY5PR12MB6647:EE_ X-MS-Office365-Filtering-Correlation-Id: 22e1bdf9-7d13-47c6-08d6-08ddeeeab608 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GEfq8SK3CQoWgLi4/E0h7epeMmhnzKB+QTpQo3eRU3bCNz1YWdn54d1egOKQ?= =?us-ascii?Q?ouQxI7idFPmgB73D4qSmfeoBUsM1OAzRY8AtAOJSuw7EFVACU82/8CWfYpyO?= =?us-ascii?Q?oJsZQRx/1AGgDxfUJNYln3ikVNZIT+EQzK0U11RkOoQvJt8dHxzTUoDY2oLO?= =?us-ascii?Q?9m42wZXeyIwBMl9vXywWJWr/m0Lw6dhOJbPTR5NxrZtJLM2w29+8uB6fGVJQ?= =?us-ascii?Q?EIkrUuFB9w5+4AFXVmgI625pVetMfJQrNPGZyMpVjpM+DvZBo+dQ1XVQv99C?= =?us-ascii?Q?jVt5RGt2OhL7trHj5fu9dqpPlyYo+AhCC1LZa5coH7iIpx+ZVDQ7MD6X6Zyw?= =?us-ascii?Q?KICtskqJl8vQxVoQULB3K93QD7mRRoJAWcK5a0siolfP9uzPXJQj1Bufgvdj?= =?us-ascii?Q?tr8puh+d8Y9cgnJ2nBgZ7fRqUDV8UpVWIXWHSWrpiUM3heay/UOq4RWFs06F?= =?us-ascii?Q?5qZofKxCO4P0abqSxqJD/Eu5MU+HcgDEpwWoLs7esU0GWVXrZke7HaBImsKD?= =?us-ascii?Q?3ers6g3ZRkMKPcV3wd4GzHtkVJuCQJPNeIj7zaPf4our6Qkx5ZEiWpl/4EGi?= =?us-ascii?Q?x3Grr0LPDSmKfUM560GN7IYK/eaD1hTpDHpQPQzQsEDxT3zIsJ6PPwf6bws+?= =?us-ascii?Q?rd87SiKdGxH8meqsWDmlxGCZ0hmOmLqtGoQrcW47SCkqS/0yrQ5SxIjqcbLl?= =?us-ascii?Q?Gm17ReTYqCj4S5XZ7Pqg0uZFUVHNjdxNyVKqWa4pdsy4uYr5ChLAthJae/uy?= =?us-ascii?Q?oXxo3HRPlM9iT3DLSS9v0JI4s2osQtdKF5o/EtVJSxBOps0ys7crsWaRa2ZT?= =?us-ascii?Q?NY7RXtUHFT8vZ2nXKYU1/i8hAWP92iL6c+3ALGC6CxPA1kfk0mMWn5r8QRnR?= =?us-ascii?Q?aE7wtnXiaV9Wn1VktKE2F6TtzkcQgCyuTFOCUVqurJd+vFt6l82WJA6YtpnO?= =?us-ascii?Q?I4QyHqKoCRfh9h08V+jKSdG7oHazxeulPAR625JZuvZC0MRLDKKaocL8aAUQ?= =?us-ascii?Q?a034pUt+wOvFhDoZRcXqkftuSf7IuFH3ql4XTEJaCQ4DQypc1ttTvL6i6HZL?= =?us-ascii?Q?ESZl5KHq9eDfWKjH3GDbdC0AzDqURDXuw3fcg4rWlUgxqK/gywAD+E4WbmJK?= =?us-ascii?Q?wv35RR8xGwiLegY/A6XmSrbmKISrMiG0XzdfqDnbEjCjIQ8G3iTu8KuOEE/a?= =?us-ascii?Q?ZlrJDRhNpMycj3fpnNBv7l/AGXrZAHsP4hCq0yieqPWEed5DFybIjMH+M6mk?= =?us-ascii?Q?x9ApO7yN1h/Hd7o3ks0K9XU4J5arFOyXpDynvP31xpvxKisWKxe2jb17Jt1J?= =?us-ascii?Q?a1kBoxoOTNAP1Tx4+W0uipZ5ML/BwEZU8r+3d0uTsDB1iiBAWykrp4jSKF9p?= =?us-ascii?Q?FM0DWu43708giy2+Eww7dEh69nXIY7MWB4FaJ/lqepEN1IQS0p/8J3ngyoGh?= =?us-ascii?Q?9en5VPMv+ao=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB5757.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7FJCsWxOPBRG/VWdY/N8zALehIFQ036c94s9ivCv276zNmbjChxo2KwOsFYn?= =?us-ascii?Q?XqY0q6mLY5W2Yx5ZCI9G5ovb5piNzD7T7E8/TbZneRG3TAIRaZLHZWxR09rf?= =?us-ascii?Q?ZruImfcUfHQs+TRilvAaBzBhYvKaWsPz6inNSOWLsmXqkp+8RWa8QtR9bmMC?= =?us-ascii?Q?262VXRnY7ye8fTxj7pGuRqjpP9wBpjuXO6HbAxO1YNQ0zl9b1qkzE/nGQ4Jy?= =?us-ascii?Q?yS6VhNzoOZbzcLKyhNQA7QvDSsl+ZWo/tFg07T6afoCzyKX4vRzGRjoj31Up?= =?us-ascii?Q?kCFtmo8ZlxpWKq5EmPkb0p+wBWiV7SEFL825r9Y4P4hhk7zhwnmRz20HVFpR?= =?us-ascii?Q?A3NNIFn2jiEEXS7sJ1YT5Npf7SI1WR3q6Sx2qcoLObEVmg1AHUebvbmwshJ2?= =?us-ascii?Q?+IGWddmnOOx3/mYuaM7mFh1ciq7C28LiNxMvRFGqKCaX19qGoYePzNcCMU/W?= =?us-ascii?Q?4W8EcvNNgLHpTixbaS2ivj0ZkS1T1LzUNlvn3OO/k9mYdqUZ8Fbb8zKvkYWD?= =?us-ascii?Q?XzbcvimnUCM+FzbCi2wCBYTCtGAqGn/vT/qmbjnInjxH5JZbcrBNLTusUNC1?= =?us-ascii?Q?YwIrQ/nv9AOrI1qm/OwsQD9ORqdpRKcViSoul+B+Nh4pCzfcXrt1l/7UdfXL?= =?us-ascii?Q?fdGhXhzYU/OncOKw95ufrH1yBDa+sjb5Bzafrf0nXr+43ePun/mqJRYcHsvU?= =?us-ascii?Q?3wlfVxg2rAgCdbDJElaghWHyW+mLen2FY9W+Zg30zLmcKJFpxoPy+sGn3mqA?= =?us-ascii?Q?VZPk6Y8TiaR06FYdf/nhYEHke0gCnn8n09chJwD40ubvSHvRadgTVsRvW7Sa?= =?us-ascii?Q?YHYRohJvpKDX54M/NDeVgMtH2GwDAIpVk09RLS0PAB0ygU2Y1Reoo6bJzhzC?= =?us-ascii?Q?C3ULhdFh3pbDO7iURNfRRbG1F3IcRKxS+7cjKlbwQn1baxnNMjR9fpqsVUQa?= =?us-ascii?Q?hYNgCHdV6udNmTaPaLLazznaTYpdarAHoYcRofRYP3K2iA2k1uVG6XZkye0N?= =?us-ascii?Q?EbRTRG5+KXfd6VnN+lGlcnXCUKCYnc3/mj70sAfE0wqn6ggBipzLzZ06lppy?= =?us-ascii?Q?pGZFtaizIdrkv0VsTOSazzPIR0WcW5Y6TxB8x15OlP4NJd94hBQhTjLrj7wU?= =?us-ascii?Q?FKXkf42air+mlHRQmJG5psKDRj9Uk73mhdKweNJE/bNHv4P1o7U/map0ZRaC?= =?us-ascii?Q?wSW7Hr0DTJcUArP3lCh8dvO9qVHQOckyGDBJ5Jsv1uOPVJC/gO0czY/FXWUJ?= =?us-ascii?Q?hXdd4kmKDP+OlIv1XRptgmwNB9bfKPieerkQ+ywBRrYMKXHgzmWUVrRqmjaL?= =?us-ascii?Q?54EikFLwMMA+L0RckaG6tHd6fdsOkOGpmb0QU2U+WGtSFVal6daGPrEzRX1W?= =?us-ascii?Q?AuhrwbVd8Cm14lX+Rwl9ETbEy38JXebh9JKBCQ77HFLVa5B6vEuO7khFT3hR?= =?us-ascii?Q?GsCA18aJArsZefDBhsu7kto1cTDKGcUAUGapW2yL0GGpc6sdgpoVTU8aLkgH?= =?us-ascii?Q?N4B2lPsRGuahIkUI13qiyS9R1eA88fKYWiRUr3Jut5ESx+6PvCb752BZaxyc?= =?us-ascii?Q?xOrenGxP1WzbMQB2gIo=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22e1bdf9-7d13-47c6-08d6-08ddeeeab608 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5757.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2025 15:16:40.1755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1tpI3YIsTiLSBDyil/y84udvyR+SIk9BaK4Mip9D8I/ZS854FMCO4alMjdflmiBP X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6647 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 56C92C000B X-Stat-Signature: tffpnk41nrmzoptdp4qoqhi8uaeeixn3 X-HE-Tag: 1757344610-398340 X-HE-Meta: U2FsdGVkX18TZPiWDVu/ED+WBKThutvVRwMAVPDu4VYQ4oeYLvW63VDUjUYGPEqlqakwy4OutEH1PfIZlb9th4X3tks3DS9p8TUxLrPKXF8W6Ztaq7pb7jvWJuHVgoUmK+IUdq7dXEnymQ7Pto6zuywtoY3bduVzD3BaToybrm368u38xBOaSnUShEmJDE9mXldj8xtS/CbQF1Q6oZ7Ckb9Py15b7BBzYOxTdLzwM6s/Buim+D0R66teoL7uqwqqM41xPpAS+c8bQp2YD3TgJvJBnRm7bWqhaFpVqHiO9KdoooxPkAlk3qMTKwWWYoKT6uABINhM7P5Vcn7Jh0kft7msCUCFpf4cznD9c27HGG249EA5kOAcfzSGrOcAvwiSbBev8OPI+z9Dcqfa8LMdRwv/kMgQG1wRJH66uRPBiaJB9dGF4B52/4VkAn3ZdwE7GNOqoFWPF3dZeqdqIwQ0unMlWRu6uPgtDEFLl1tB1oPVRjzHSNiG+LB5wKkT723nWEqtjW+ozexR3AgMq7di7gljk3ItwI2a4JFQNaTtETXPDIQ/V1GPs9YzDLQ7eCCl+6TnKFlk9rLePOzbmVhACoC67INkeIj3JbJaZ/nFCmIAGHxGHh9cIp89ePNVwd/ftEDyyppf8Af1/aaM34roxHPTOL5maoC06+8J3zhuCMEgfDiuF/zJ8/YQYIQcd/ckYOXBvqF4ojko48ZSV/9mOylm9VUN1HmltihoLOWqYV6eW7INDviwFLShQkT/URpLg71Q9Kx556JTIQaBhUU16L3KXsT4s8LSAVG9EGxpTbeYGgkkvYY2VAOzTfZsOHjCFvA702kYjm5WTaca6v+OqTw/bwQmuAoMxOwJDuLyj/AMhKeP+qgpiQBdRC1UbFDPbajqVWn/TJc48KLk26rrC38VhNg2YJxpJTLmSnMjxM07woqHs0herN+teTGMyMIgt3/PBrYEHWDW94XLsT3 4AlHkQ56 7kw1+DYuj1z6UpRxnmN898pZ+yo191Y6N8BdowHF1rJEUoUIf8W6VoFWFEbT3hcfmdnV0XNBRqLyzMe7e05omRj9ZoNToLEmjOrBmLSj//vDD8Pb/mdwOfiHtrj49NB53vXXL+WTAKNmqZGBPte7IDDsRT1dLujz2xm9eyzf62riZawHLylfub4zOTfl4EZNkBqAOu51XixAEIam1cPC0IFqI2GX17xUwa6IYYf2/w2ppn/yfp9BvisS5rwZoXH+gfoMMiSdgEoXpPt+KJUkpcIBaSm9hxGuVRl9qVyyVhoxNaMW/VjDZCNAf2lkjVcTAC9Skjt5PFYia0szJFMBWOa9QNeB6Hj3LemLG1GvzsrVnECWyGNrQNrx+aQuYyRhYifpksvN4h1/rebpJQMFnDyrdKLPB+5v4kTztBLwdOHAiL7R0ji6RDxJnfXfBy/WQcCKq9I1eIaTf0k4pXAZuGZKzly56+UDV3urCZckkfkG4JkWyjLJzGWDRDnIOKX9k+oUND/qLABVe0V9mKuAss1+NuA8jN2Cx7wtuK8W4p9kQ5cdGA4soaJJ8rip8offPZaSTpJYiY93BOqdySzUd9BE/lkSOM8I+wYjukWGjR4uNJi0xP6+8k7mtwr1CJtxVTLN3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 08, 2025 at 03:47:34PM +0100, Lorenzo Stoakes wrote: > On Mon, Sep 08, 2025 at 11:20:11AM -0300, Jason Gunthorpe wrote: > > On Mon, Sep 08, 2025 at 03:09:43PM +0100, Lorenzo Stoakes wrote: > > > > Perhaps > > > > > > > > !vma_desc_cowable() > > > > > > > > Is what many drivers are really trying to assert. > > > > > > Well no, because: > > > > > > static inline bool is_cow_mapping(vm_flags_t flags) > > > { > > > return (flags & (VM_SHARED | VM_MAYWRITE)) == VM_MAYWRITE; > > > } > > > > > > Read-only means !CoW. > > > > What drivers want when they check SHARED is to prevent COW. It is COW > > that causes problems for whatever the driver is doing, so calling the > > helper cowable and making the test actually right for is a good thing. > > > > COW of this VMA, and no possibilty to remap/mprotect/fork/etc it into > > something that is COW in future. > > But you can't do that if !VM_MAYWRITE. See this is my fear, the drivers are wrong and you are talking about edge cases nobody actually knows about. The need is the created VMA, and its dups, never, ever becomes COWable. This is what drivers actually want. We need to give them a clear test to do that. Anything using remap and checking for SHARED almost certainly falls into this category as COWing remapped memory is rare and weird. > I mean probably the driver's just wrong and should use > is_cow_mapping() tbh. Maybe. > I think we need to be cautious of scope here :) I don't want to > accidentally break things this way. IMHO it is worth doing when you get into more driver places it is far more obvious why the VM_SHARED is being checked. > OK I think a sensible way forward - How about I add desc_is_cowable() or > vma_desc_cowable() and only set this if I'm confident it's correct? I'm thinking to call it vma_desc_never_cowable() as that is much much clear what the purpose is. I think anyone just checking VM_SHARED should be changed over.. Jason