[PATCH v1 1/1] mapple_tree: Fix build error (`make W=1`)

[PATCH v1 1/1] mapple_tree: Fix build error (`make W=1`)

[Andy Shevchenko]

clang complains about unused function:

lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]

Fix this by removing unused code.

Fixes: a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 lib/maple_tree.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index fce329d6c1b2..ca8b3c2e0362 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -176,11 +176,6 @@ static inline struct maple_node *mt_alloc_one(gfp_t gfp)
 	return kmem_cache_alloc(maple_node_cache, gfp);
 }
 
-static inline int mt_alloc_bulk(gfp_t gfp, size_t size, void **nodes)
-{
-	return kmem_cache_alloc_bulk(maple_node_cache, gfp, size, nodes);
-}
-
 static inline void mt_free_bulk(size_t size, void __rcu **nodes)
 {
 	kmem_cache_free_bulk(maple_node_cache, size, (void **)nodes);
-- 
2.50.1

Re: [PATCH v1 1/1] mapple_tree: Fix build error (`make W=1`)

[Liam R. Howlett]

* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 05:04]:
> clang complains about unused function:
> 
> lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]
> 
> Fix this by removing unused code.
> 
> Fixes: a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks.  This should be squashed into the patch listed in the fixes tag
since it's not a stable commit yet.

> ---
>  lib/maple_tree.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index fce329d6c1b2..ca8b3c2e0362 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -176,11 +176,6 @@ static inline struct maple_node *mt_alloc_one(gfp_t gfp)
>  	return kmem_cache_alloc(maple_node_cache, gfp);
>  }
>  
> -static inline int mt_alloc_bulk(gfp_t gfp, size_t size, void **nodes)
> -{
> -	return kmem_cache_alloc_bulk(maple_node_cache, gfp, size, nodes);
> -}
> -
>  static inline void mt_free_bulk(size_t size, void __rcu **nodes)
>  {
>  	kmem_cache_free_bulk(maple_node_cache, size, (void **)nodes);
> -- 
> 2.50.1
> 

Re: [PATCH v1 1/1] mapple_tree: Fix build error (`make W=1`)

[Andy Shevchenko]

On Thu, Sep 04, 2025 at 09:32:52AM -0400, Liam R. Howlett wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 05:04]:
> > clang complains about unused function:
> > 
> > lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]
> > 
> > Fix this by removing unused code.
> > 
> > Fixes: a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Thanks.  This should be squashed into the patch listed in the fixes tag
> since it's not a stable commit yet.

I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] mapple_tree: Fix build error (`make W=1`)

[Liam R. Howlett]

* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 09:37]:
> On Thu, Sep 04, 2025 at 09:32:52AM -0400, Liam R. Howlett wrote:
> > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 05:04]:
> > > clang complains about unused function:
> > > 
> > > lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]
> > > 
> > > Fix this by removing unused code.
> > > 
> > > Fixes: a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > Thanks.  This should be squashed into the patch listed in the fixes tag
> > since it's not a stable commit yet.
> 
> I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!

Sounds good.  I've added Vlastimil to the email as it went through his
branch.

Can you please Cc the SoB people next time?

Thanks,
Liam

Re: [PATCH v1 1/1] mapple_tree: Fix build error (`make W=1`)

[Andy Shevchenko]

On Thu, Sep 04, 2025 at 09:42:53AM -0400, Liam R. Howlett wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 09:37]:
> > On Thu, Sep 04, 2025 at 09:32:52AM -0400, Liam R. Howlett wrote:
> > > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 05:04]:
> > > > clang complains about unused function:
> > > > 
> > > > lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]
> > > > 
> > > > Fix this by removing unused code.
> > > > 
> > > > Fixes: a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > 
> > > Thanks.  This should be squashed into the patch listed in the fixes tag
> > > since it's not a stable commit yet.
> > 
> > I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!
> 
> Sounds good.  I've added Vlastimil to the email as it went through his
> branch.
> 
> Can you please Cc the SoB people next time?

I will try to remember. I used get_maintainers.pl. If it's not enough,
can we got this documented somehow? Or if it's already documented,
can you point out to it?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] mapple_tree: Fix build error (`make W=1`)

[Vlastimil Babka]

On 9/4/25 15:42, Liam R. Howlett wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 09:37]:
>> On Thu, Sep 04, 2025 at 09:32:52AM -0400, Liam R. Howlett wrote:
>> > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [250904 05:04]:
>> > > clang complains about unused function:
>> > > 
>> > > lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]
>> > > 
>> > > Fix this by removing unused code.
>> > > 
>> > > Fixes: a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
>> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> > 
>> > Thanks.  This should be squashed into the patch listed in the fixes tag
>> > since it's not a stable commit yet.
>> 
>> I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!
> 
> Sounds good.  I've added Vlastimil to the email as it went through his
> branch.

Squashing into the tomorrow's linux-next release, thanks.

> Can you please Cc the SoB people next time?
> 
> Thanks,
> Liam