From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-block@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-efi@vger.kernel.org, virtualization@lists.linux.dev,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [PATCH v3 7/7] virtio_balloon: Stop calling page_address() in free_pages()
Date: Wed, 3 Sep 2025 11:59:21 -0700 [thread overview]
Message-ID: <20250903185921.1785167-8-vishal.moola@gmail.com> (raw)
In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com>
free_pages() should be used when we only have a virtual address. We
should call __free_pages() directly on our page instead.
Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
---
drivers/virtio/virtio_balloon.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index eae65136cdfb..7f3fd72678eb 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -488,8 +488,7 @@ static unsigned long return_free_pages_to_mm(struct virtio_balloon *vb,
page = balloon_page_pop(&vb->free_page_list);
if (!page)
break;
- free_pages((unsigned long)page_address(page),
- VIRTIO_BALLOON_HINT_BLOCK_ORDER);
+ __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER);
}
vb->num_free_page_blocks -= num_returned;
spin_unlock_irq(&vb->free_page_list_lock);
@@ -719,8 +718,7 @@ static int get_free_page_and_send(struct virtio_balloon *vb)
if (vq->num_free > 1) {
err = virtqueue_add_inbuf(vq, &sg, 1, p, GFP_KERNEL);
if (unlikely(err)) {
- free_pages((unsigned long)p,
- VIRTIO_BALLOON_HINT_BLOCK_ORDER);
+ __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER);
return err;
}
virtqueue_kick(vq);
@@ -733,7 +731,7 @@ static int get_free_page_and_send(struct virtio_balloon *vb)
* The vq has no available entry to add this page block, so
* just free it.
*/
- free_pages((unsigned long)p, VIRTIO_BALLOON_HINT_BLOCK_ORDER);
+ __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER);
}
return 0;
--
2.51.0
next prev parent reply other threads:[~2025-09-03 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 18:59 [PATCH v3 0/7] Cleanup free_pages() misuse Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 1/7] mm/page_alloc: Add kernel-docs for free_pages() Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 2/7] aoe: Stop calling page_address() in free_page() Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 3/7] x86: Stop calling page_address() in free_pages() Vishal Moola (Oracle)
2025-09-04 11:51 ` Mike Rapoport
2025-09-04 11:54 ` Mike Rapoport
2025-09-05 18:02 ` Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 4/7] riscv: " Vishal Moola (Oracle)
2025-09-04 12:27 ` Alexandre Ghiti
2025-09-03 18:59 ` [PATCH v3 5/7] powerpc: " Vishal Moola (Oracle)
2025-09-04 7:10 ` Christophe Leroy
2025-09-03 18:59 ` [PATCH v3 6/7] arm64: " Vishal Moola (Oracle)
2025-09-03 18:59 ` Vishal Moola (Oracle) [this message]
2025-09-03 19:13 ` [PATCH v3 7/7] virtio_balloon: " David Hildenbrand
2025-09-04 21:38 ` Michael S. Tsirkin
2025-09-04 11:55 ` [PATCH v3 0/7] Cleanup free_pages() misuse Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903185921.1785167-8-vishal.moola@gmail.com \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox