linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ankur Arora <ankur.a.arora@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org
Cc: akpm@linux-foundation.org, david@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
	mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org,
	acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de,
	willy@infradead.org, raghavendra.kt@amd.com,
	boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
	ankur.a.arora@oracle.com
Subject: [PATCH v6 08/15] perf bench mem: Refactor mem_options
Date: Tue,  2 Sep 2025 01:08:09 -0700	[thread overview]
Message-ID: <20250902080816.3715913-9-ankur.a.arora@oracle.com> (raw)
In-Reply-To: <20250902080816.3715913-1-ankur.a.arora@oracle.com>

Split mem benchmark options into common and memset/memcpy specific.

Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
---
 tools/perf/bench/mem-functions.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/tools/perf/bench/mem-functions.c b/tools/perf/bench/mem-functions.c
index 69968ba63d81..2a23bed8c2d3 100644
--- a/tools/perf/bench/mem-functions.c
+++ b/tools/perf/bench/mem-functions.c
@@ -41,7 +41,7 @@ static unsigned int	nr_loops	= 1;
 static bool		use_cycles;
 static int		cycles_fd;
 
-static const struct option options[] = {
+static const struct option bench_common_options[] = {
 	OPT_STRING('s', "size", &size_str, "1MB",
 		    "Specify the size of the memory buffers. "
 		    "Available units: B, KB, MB, GB and TB (case insensitive)"),
@@ -50,10 +50,6 @@ static const struct option options[] = {
 		    "Specify page-size for mapping memory buffers. "
 		    "Available sizes: 4KB, 2MB, 1GB (case insensitive)"),
 
-	OPT_STRING('k', "chunk", &chunk_size_str, "0",
-		    "Specify the chunk-size for each invocation. "
-		    "Available units: B, KB, MB, GB and TB (case insensitive)"),
-
 	OPT_STRING('f', "function", &function_str, "all",
 		    "Specify the function to run, \"all\" runs all available functions, \"help\" lists them"),
 
@@ -66,6 +62,14 @@ static const struct option options[] = {
 	OPT_END()
 };
 
+static const struct option bench_mem_options[] = {
+	OPT_STRING('k', "chunk", &chunk_size_str, "0",
+		    "Specify the chunk-size for each invocation. "
+		    "Available units: B, KB, MB, GB and TB (case insensitive)"),
+	OPT_PARENT(bench_common_options),
+	OPT_END()
+};
+
 union bench_clock {
 	u64		cycles;
 	struct timeval	tv;
@@ -84,6 +88,7 @@ struct bench_mem_info {
 	int (*do_op)(const struct function *r, struct bench_params *p,
 		     void *src, void *dst, union bench_clock *rt);
 	const char *const *usage;
+	const struct option *options;
 	bool alloc_src;
 };
 
@@ -230,7 +235,7 @@ static int bench_mem_common(int argc, const char **argv, struct bench_mem_info *
 	struct bench_params p = { 0 };
 	unsigned int page_size;
 
-	argc = parse_options(argc, argv, options, info->usage, 0);
+	argc = parse_options(argc, argv, info->options, info->usage, 0);
 
 	if (use_cycles) {
 		i = init_cycles();
@@ -397,6 +402,7 @@ int bench_mem_memcpy(int argc, const char **argv)
 		.functions		= memcpy_functions,
 		.do_op			= do_memcpy,
 		.usage			= bench_mem_memcpy_usage,
+		.options		= bench_mem_options,
 		.alloc_src              = true,
 	};
 
@@ -454,6 +460,7 @@ int bench_mem_memset(int argc, const char **argv)
 		.functions		= memset_functions,
 		.do_op			= do_memset,
 		.usage			= bench_mem_memset_usage,
+		.options		= bench_mem_options,
 	};
 
 	return bench_mem_common(argc, argv, &info);
-- 
2.31.1



  parent reply	other threads:[~2025-09-02  9:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02  8:08 [PATCH v6 00/15] mm: folio_zero_user: clear contiguous pages Ankur Arora
2025-09-02  8:08 ` [PATCH v6 01/15] perf bench mem: Remove repetition around time measurement Ankur Arora
2025-09-02  8:08 ` [PATCH v6 02/15] perf bench mem: Defer type munging of size to float Ankur Arora
2025-09-02  8:08 ` [PATCH v6 03/15] perf bench mem: Move mem op parameters into a structure Ankur Arora
2025-09-02  8:08 ` [PATCH v6 04/15] perf bench mem: Pull out init/fini logic Ankur Arora
2025-09-02  8:08 ` [PATCH v6 05/15] perf bench mem: Switch from zalloc() to mmap() Ankur Arora
2025-09-02  8:08 ` [PATCH v6 06/15] perf bench mem: Allow mapping of hugepages Ankur Arora
2025-09-02  8:08 ` [PATCH v6 07/15] perf bench mem: Allow chunking on a memory region Ankur Arora
2025-09-02  8:08 ` Ankur Arora [this message]
2025-09-02  8:08 ` [PATCH v6 09/15] perf bench mem: Add mmap() workloads Ankur Arora
2025-09-02  8:08 ` [PATCH v6 10/15] x86/mm: Simplify clear_page_* Ankur Arora
2025-09-02  8:08 ` [PATCH v6 11/15] mm: define clear_pages(), clear_user_pages() Ankur Arora
2025-09-02 19:56   ` kernel test robot
2025-09-02 20:09   ` kernel test robot
2025-09-02 20:16   ` David Hildenbrand
2025-09-03  4:08     ` Ankur Arora
2025-09-12 21:17       ` Ankur Arora
2025-09-02  8:08 ` [PATCH v6 12/15] highmem: define clear_highpages() Ankur Arora
2025-09-02 20:20   ` David Hildenbrand
2025-09-03  4:09     ` Ankur Arora
2025-09-02  8:08 ` [PATCH v6 13/15] mm: memory: support clearing page ranges Ankur Arora
2025-09-02 19:46   ` kernel test robot
2025-09-02  8:08 ` [PATCH v6 14/15] x86/clear_page: Introduce clear_pages() Ankur Arora
2025-09-02  8:08 ` [PATCH v6 15/15] x86/clear_pages: Support clearing of page-extents Ankur Arora
2025-09-12 18:33 ` [PATCH v6 00/15] mm: folio_zero_user: clear contiguous pages Arnaldo Carvalho de Melo
2025-09-12 21:12   ` Ankur Arora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250902080816.3715913-9-ankur.a.arora@oracle.com \
    --to=ankur.a.arora@oracle.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mjguzik@gmail.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@amd.com \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox