From: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Subject: [PATCH] tools/mm/slabinfo: fix buffer overflows in fread operations
Date: Fri, 29 Aug 2025 15:29:47 +0530 [thread overview]
Message-ID: <20250829095947.1828094-1-kaushlendra.kumar@intel.com> (raw)
The fread() calls in read_slab_obj() and read_debug_slab_obj() can read
up to sizeof(buffer) bytes, but then unconditionally write a null
terminator at buffer[l]. If fread() returns sizeof(buffer), this writes
beyond the allocated buffer boundaries.
Fix by limiting reads to sizeof(buffer) - 1 bytes in both functions,
ensuring space is always reserved for null termination. This prevents
buffer overflows while maintaining proper string handling.
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
tools/mm/slabinfo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/mm/slabinfo.c b/tools/mm/slabinfo.c
index 1433eff99feb..1a7f2874c625 100644
--- a/tools/mm/slabinfo.c
+++ b/tools/mm/slabinfo.c
@@ -228,7 +228,7 @@ static unsigned long read_slab_obj(struct slabinfo *s, const char *name)
buffer[0] = 0;
l = 0;
} else {
- l = fread(buffer, 1, sizeof(buffer), f);
+ l = fread(buffer, 1, sizeof(buffer) - 1, f);
buffer[l] = 0;
fclose(f);
}
@@ -247,7 +247,7 @@ static unsigned long read_debug_slab_obj(struct slabinfo *s, const char *name)
buffer[0] = 0;
l = 0;
} else {
- l = fread(buffer, 1, sizeof(buffer), f);
+ l = fread(buffer, 1, sizeof(buffer) - 1, f);
buffer[l] = 0;
fclose(f);
}
--
2.34.1
next reply other threads:[~2025-08-29 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 9:59 Kaushlendra Kumar [this message]
2025-08-29 11:51 ` Harry Yoo
2025-08-29 13:12 ` Kumar, Kaushlendra
2025-08-29 15:30 ` Kumar, Kaushlendra
2025-08-29 18:52 ` SeongJae Park
2025-09-22 2:40 ` Kumar, Kaushlendra
2025-09-22 9:45 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829095947.1828094-1-kaushlendra.kumar@intel.com \
--to=kaushlendra.kumar@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox