From: zhongjinji <zhongjinji@honor.com>
To: <mhocko@suse.com>
Cc: <rientjes@google.com>, <shakeel.butt@linux.dev>,
<akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <tglx@linutronix.de>,
<liam.howlett@oracle.com>, <lorenzo.stoakes@oracle.com>,
<surenb@google.com>, <liulu.liu@honor.com>, <feng.han@honor.com>,
<tianxiaobin@honor.com>, <fengbaopeng@honor.com>,
<zhongjinji@honor.com>
Subject: [PATCH v6 1/2] mm/oom_kill: Do not delay oom reaper when the victim is frozen
Date: Fri, 29 Aug 2025 14:55:49 +0800 [thread overview]
Message-ID: <20250829065550.29571-2-zhongjinji@honor.com> (raw)
In-Reply-To: <20250829065550.29571-1-zhongjinji@honor.com>
The oom reaper is a mechanism to guarantee a forward process during OOM
situation when the oom victim cannot terminate on its own (e.g. being
blocked in uninterruptible state or frozen by cgroup freezer). In order
to give the victim some time to terminate properly the oom reaper is
delayed in its invocation. This is particularly beneficial when the oom
victim is holding robust futex resources as the anonymous memory tear
down can break those. [1]
On the other hand deliberately frozen tasks by the freezer cgroup will
not wake up until they are thawed in the userspace and delay is
effectively pointless. Therefore opt out from the delay for cgroup
frozen oom victims.
Reference:
[1] https://lore.kernel.org/all/20220414144042.677008-1-npache@redhat.com/T/#u
Signed-off-by: zhongjinji <zhongjinji@honor.com>
---
mm/oom_kill.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 25923cfec9c6..a5e9074896a1 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -700,7 +700,14 @@ static void queue_oom_reaper(struct task_struct *tsk)
get_task_struct(tsk);
timer_setup(&tsk->oom_reaper_timer, wake_oom_reaper, 0);
- tsk->oom_reaper_timer.expires = jiffies + OOM_REAPER_DELAY;
+ tsk->oom_reaper_timer.expires = jiffies;
+
+ /*
+ * If the task is frozen by the cgroup freezer, the delay is unnecessary
+ * because it cannot exit until thawed. Skip the delay for frozen victims.
+ */
+ if (!frozen(tsk))
+ tsk->oom_reaper_timer.expires += OOM_REAPER_DELAY;
add_timer(&tsk->oom_reaper_timer);
}
--
2.17.1
next prev parent reply other threads:[~2025-08-29 6:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 6:55 [PATCH v6 0/2] Do not delay OOM " zhongjinji
2025-08-29 6:55 ` zhongjinji [this message]
2025-08-29 9:57 ` [PATCH v6 1/2] mm/oom_kill: Do not delay oom " Lorenzo Stoakes
2025-08-29 17:30 ` Liam R. Howlett
2025-08-29 23:20 ` Shakeel Butt
2025-09-01 13:17 ` zhongjinji
2025-09-01 7:25 ` Michal Hocko
2025-09-01 9:30 ` zhongjinji
2025-09-01 13:58 ` Michal Hocko
2025-09-02 16:01 ` zhongjinji
2025-09-03 7:00 ` Michal Hocko
2025-08-29 6:55 ` [PATCH v6 2/2] mm/oom_kill: The OOM reaper traverses the VMA maple tree in reverse order zhongjinji
2025-08-29 10:00 ` Lorenzo Stoakes
2025-08-29 17:31 ` Liam R. Howlett
2025-08-29 23:21 ` Shakeel Butt
2025-09-01 7:41 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829065550.29571-2-zhongjinji@honor.com \
--to=zhongjinji@honor.com \
--cc=akpm@linux-foundation.org \
--cc=feng.han@honor.com \
--cc=fengbaopeng@honor.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liulu.liu@honor.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=tianxiaobin@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox