From: Jinchao Wang <wangjinchao600@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Naveen N . Rao" <naveen@kernel.org>,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jinchao Wang <wangjinchao600@gmail.com>
Subject: [PATCH 10/17] mm/ksw: coordinate watch and stack for full functionality
Date: Thu, 28 Aug 2025 15:32:43 +0800 [thread overview]
Message-ID: <20250828073311.1116593-11-wangjinchao600@gmail.com> (raw)
In-Reply-To: <20250828073311.1116593-1-wangjinchao600@gmail.com>
This patch connects the watch and stack so that all components function
together.
Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
---
mm/kstackwatch/kernel.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c
index 95ade95abde1..4c5fbcaddab0 100644
--- a/mm/kstackwatch/kernel.c
+++ b/mm/kstackwatch/kernel.c
@@ -1,10 +1,13 @@
// SPDX-License-Identifier: GPL-2.0
+#include <linux/kern_levels.h>
+#include <linux/kernel.h>
#include <linux/kstrtox.h>
#include <linux/module.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/string.h>
#include <linux/uaccess.h>
+#include <linux/utsname.h>
#include "kstackwatch.h"
@@ -22,6 +25,29 @@ MODULE_PARM_DESC(panic_on_catch,
static int ksw_start_watching(void)
{
+ int ret;
+
+ if (strlen(ksw_config->function) == 0) {
+ pr_err("KSW: no target function specified\n");
+ return -EINVAL;
+ }
+
+ /*
+ * Watch init will preallocate the HWBP,
+ * so it must happen before stack init
+ */
+ ret = ksw_watch_init(ksw_config);
+ if (ret) {
+ pr_err("KSW: ksw_watch_init ret: %d\n", ret);
+ return ret;
+ }
+
+ ret = ksw_stack_init(ksw_config);
+ if (ret) {
+ pr_err("KSW: ksw_stack_init_fprobe ret: %d\n", ret);
+ ksw_watch_exit();
+ return ret;
+ }
watching_active = true;
pr_info("KSW: start watching %s\n", ksw_config->config_str);
@@ -30,6 +56,8 @@ static int ksw_start_watching(void)
static void ksw_stop_watching(void)
{
+ ksw_stack_exit();
+ ksw_watch_exit();
watching_active = false;
pr_info("KSW: stop watching %s\n", ksw_config->config_str);
--
2.43.0
next prev parent reply other threads:[~2025-08-28 7:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 7:32 [PATCH 00/17] mm/ksw: Introduce real-time Kernel Stack Watch debugging tool Jinchao Wang
2025-08-28 7:32 ` [PATCH 01/17] mm/ksw: add build system support Jinchao Wang
2025-08-28 7:32 ` [PATCH 02/17] mm/ksw: add ksw_config struct and parser Jinchao Wang
2025-08-28 7:32 ` [PATCH 03/17] mm/ksw: add /proc/kstackwatch interface Jinchao Wang
2025-08-28 7:32 ` [PATCH 04/17] mm/ksw: add HWBP pre-allocation support Jinchao Wang
2025-08-28 7:32 ` [PATCH 05/17] x86/HWBP: introduce arch_reinstall_hw_breakpoint() for atomic context Jinchao Wang
2025-08-28 7:32 ` [PATCH 06/17] mm/ksw: add atomic watch on/off operations Jinchao Wang
2025-08-28 7:32 ` [PATCH 07/17] mm/ksw: add stack probe support Jinchao Wang
2025-08-28 7:32 ` [PATCH 08/17] mm/ksw: implement stack canary and local var resolution logic Jinchao Wang
2025-08-28 7:32 ` [PATCH 09/17] mm/ksw: add per-task recursion depth tracking Jinchao Wang
2025-08-28 7:32 ` Jinchao Wang [this message]
2025-08-28 7:32 ` [PATCH 11/17] mm/ksw: add self-debug functions for kstackwatch watch Jinchao Wang
2025-08-28 7:32 ` [PATCH 12/17] mm/ksw: add test module Jinchao Wang
2025-08-28 7:32 ` [PATCH 13/17] mm/ksw: add stack overflow test Jinchao Wang
2025-08-28 7:32 ` [PATCH 14/17] mm/ksw: add simplified silent corruption test Jinchao Wang
2025-08-28 7:32 ` [PATCH 15/17] mm/ksw: add recursive " Jinchao Wang
2025-08-28 7:32 ` [PATCH 16/17] tools/kstackwatch: add interactive test script for KStackWatch Jinchao Wang
2025-08-28 7:32 ` [PATCH 17/17] MAINTAINERS: add entry for KStackWatch (Kernel Stack Watch) Jinchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828073311.1116593-11-wangjinchao600@gmail.com \
--to=wangjinchao600@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox