linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: <muchun.song@linux.dev>, <osalvador@suse.de>, <david@redhat.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "hugetlb: make hugetlb depends on SYSFS or SYSCTL"
Date: Wed, 27 Aug 2025 19:49:34 -0700	[thread overview]
Message-ID: <20250827194934.f30fe19856fc343005c9703f@linux-foundation.org> (raw)
In-Reply-To: <0138514f-c580-c066-c16d-2a0b207e0604@huawei.com>

On Thu, 28 Aug 2025 10:31:51 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:

> On 2025/8/27 11:35, Andrew Morton wrote:
> > On Tue, 26 Aug 2025 11:09:55 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> > 
> >> Commit f8142cf94d47 ("hugetlb: make hugetlb depends on SYSFS or SYSCTL")
> >> added dependency on SYSFS or SYSCTL but hugetlb can be used without SYSFS
> >> or SYSCTL. So this dependency is wrong and should be removed.
> >>
> >> This reverts commit f8142cf94d4737ea0c3baffb3b9bad8addcb9b6b.
> > 
> > f8142cf94d47 said:
> > 
> >     If CONFIG_SYSFS and CONFIG_SYSCTL are both undefined, hugetlb
> >     doesn't work now as there's no way to set max huge pages.  Make
> >     sure at least one of the above configs is defined to make hugetlb
> >     works as expected.
> > 
> > So there is now a way to set max huge pages?  A reference tot he
> > commit which made f8142cf94d47 unneeded might be helpful?
> 
> The commit is just wrong. It overlooked the scenario of using hugetlb through boot parameters
> when it was submitted.
> 

OK.  Could we please have a description of the user-visible effect and
a decision on whether we should backport the fix?


  reply	other threads:[~2025-08-28  2:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26  3:09 Miaohe Lin
2025-08-27  3:35 ` Andrew Morton
2025-08-28  2:31   ` Miaohe Lin
2025-08-28  2:49     ` Andrew Morton [this message]
2025-08-28  3:29       ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250827194934.f30fe19856fc343005c9703f@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox