From: Wei Yang <richard.weiyang@gmail.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: David Hildenbrand <david@redhat.com>,
Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, npache@redhat.com,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
linux-mm@kvack.org, "Liam R . Howlett" <Liam.Howlett@oracle.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/khugepaged: fix the address passed to notifier on testing young
Date: Tue, 26 Aug 2025 12:51:25 +0000 [thread overview]
Message-ID: <20250826125125.7dy4stl6nikhyo3a@master> (raw)
In-Reply-To: <e9342d11-fe37-4df4-bc29-cc7f7e0ed38c@lucifer.local>
On Tue, Aug 26, 2025 at 10:03:27AM +0100, Lorenzo Stoakes wrote:
[...]
>> > referenced++;
>> > }
>> > if (!writable) {
>>
>> Maybe, just maybe, it's because of *horrible* variable naming.
>>
>> Can someone please send a cleanup to rename address -> pmd_addr and
>> _address -> pte_addr or sth like that?
>
>YES THIS.
>
>>
>> pretty much any naming is better than this.
>
>I despise it, and I realyl underlined this on review in Nico's series because
>it's just beyond belief.
>
I see your comment to Nico's series.
>It's terrible. I mean maybe even I will do something about this, if my review
>load eases up at some point...
>
If you are fine, I could help to do the renaming.
>
>Cheers, Lorenzo
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2025-08-26 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 6:33 Wei Yang
2025-08-22 7:34 ` Dev Jain
2025-08-23 1:32 ` Wei Yang
2025-08-22 7:38 ` Dev Jain
2025-08-22 7:48 ` Greg KH
2025-08-23 1:29 ` Wei Yang
2025-08-22 17:19 ` Zi Yan
2025-08-26 8:53 ` David Hildenbrand
2025-08-26 9:03 ` Lorenzo Stoakes
2025-08-26 12:51 ` Wei Yang [this message]
2025-08-26 12:49 ` Wei Yang
2025-08-26 9:07 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826125125.7dy4stl6nikhyo3a@master \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox