Re: [akpm-mm:mm-new 216/233] arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2

[Nathan Chancellor <nathan@kernel.org>]

On Fri, Aug 22, 2025 at 03:09:06PM -0700, Andrew Morton wrote:
> On Sat, 23 Aug 2025 05:30:45 +0800 kernel test robot <lkp@intel.com> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> > head:   a8af4c2fd982fd94fffde3c5b6b764fd20af68fe
> > commit: e009b0f3187482a5756ff3b015cf30277cc1cfd9 [216/233] mm/page_table_check: reinstate address parameter in [__]page_table_check_pud_clear()
> 
> > config: riscv-randconfig-001-20250823 (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d26ea02060b1c9db751d188b2edb0059a9eb273d)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202508230551.qiEQu04P-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from arch/riscv/kernel/asm-offsets.c:8:
> >    In file included from include/linux/mm.h:31:
> >    In file included from include/linux/pgtable.h:6:
> > >> arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
> >      951 |         page_table_check_pud_clear(mm, pud);
> >          |         ~~~~~~~~~~~~~~~~~~~~~~~~~~        ^
> 
> Thanks, I added this:

It appears that this fix patch was applied to the wrong patch. The error
is about page_table_check_pud_check().

> --- a/arch/riscv/include/asm/pgtable.h~mm-page_table_check-reinstate-address-parameter-in-page_table_check_pud_set-fix

But this change is about page_table_check_pud_set(), so -next is now
broken in the opposite way

  arch/riscv/include/asm/pgtable.h:951:42: error: too many arguments to function call, expected 2, have 3
    951 |         page_table_check_pud_clear(mm, address, pud);
        |         ~~~~~~~~~~~~~~~~~~~~~~~~~~              ^~~
  include/linux/page_table_check.h:125:20: note: 'page_table_check_pud_clear' declared here
    125 | static inline void page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)
        |                    ^                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

as it does not appear that e009b0f3187482a5756ff3b015cf30277cc1cfd9
is there.

> +++ a/arch/riscv/include/asm/pgtable.h
> @@ -948,7 +948,7 @@ static inline pud_t pudp_huge_get_and_cl
>  {
>  	pud_t pud = __pud(atomic_long_xchg((atomic_long_t *)pudp, 0));
>  
> -	page_table_check_pud_clear(mm, pud);
> +	page_table_check_pud_clear(mm, address, pud);
>  
>  	return pud;
>  }
> _
> 
>