From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0E62C8303F for ; Mon, 25 Aug 2025 21:37:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 344B78E0084; Mon, 25 Aug 2025 17:37:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F3FE8E0038; Mon, 25 Aug 2025 17:37:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BC438E0084; Mon, 25 Aug 2025 17:37:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 034888E0038 for ; Mon, 25 Aug 2025 17:37:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B6607C0541 for ; Mon, 25 Aug 2025 21:37:26 +0000 (UTC) X-FDA: 83816591292.30.76A47BB Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf09.hostedemail.com (Postfix) with ESMTP id 16CDC140004 for ; Mon, 25 Aug 2025 21:37:24 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cHK0J2XK; spf=pass (imf09.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1756157845; a=rsa-sha256; cv=none; b=4gU13StwJbtJ2z08DpaLSeilBv1wjV007aVzYwD4Aeu2SwGFX8tONyBVrQ0q6nRFTeKlEH Mcn3vweWsQmxnC+thj1/tHLgXZnYMGHtMbDoQPifZ4m9SRwvAfeqaeu0de2+eTsKrbQR0q WOCJn5h8tBTa+92Psw2T/9VJ9P3uCBo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cHK0J2XK; spf=pass (imf09.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1756157845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SodRd8/l8bZXSul9LRhyWd7CWue1H3vk6/6DPpbt56E=; b=Led8SHVQ59KHdMD4YaKAPH3bO7ryd1ks90Kqfi8Uux15zxwjT+HP3ofHMAJW8boCKLF6tt ZBjpwMW2Gf6cZhouRPsCyF1JsJFgNQmX92RN+dm0bJbR1uiluVtmAG6BMTyUWU1NDseRqu bmuXEmXPyR9hlirAL8t3lPC469AKcx4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D6D49406ED; Mon, 25 Aug 2025 21:37:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 567C9C113D0; Mon, 25 Aug 2025 21:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756157832; bh=R44bcAauESCYgLUnJio9oy6n01PzJ9gIprVhrTrJHrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHK0J2XKD7O53HrO4WZ8mbIIVXn1J5qjjnP+8NSiRBKE3qlSqot7fO4LiyDmh3qgE 994EaQi3GxaYUTiVcTdNq2CGuy4qPwf/BZ6vvOP7yQ30A6KQwyOxLpJ4d9L/7pKqbH 63qLEryMSPxlPH2YhbRhXt0pRoKURT7ELLjHiKpyDkSL4+J1AcoW5Sk8qXCImM2+ak p+lYv9xx85LoSuSqFv4ayEsXAVqjvuHqIqMi44uUedVEGuxxRKPPODQHHSRnAgIdh6 6clMMLqdhTofD9UT8HCFqf2Jy7NMLg5RmykPuzN+FoKKgILHRb4q6/nyDxdavQQRRP 2Gu14gyBVu0BQ== Date: Mon, 25 Aug 2025 14:37:11 -0700 From: Kees Cook To: Uladzislau Rezki Cc: Mike Rapoport , Lorenzo Stoakes , Harry Yoo , Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Christian Brauner , Jan Kara , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Oscar Salvador , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: update core kernel code to use vm_flags_t consistently Message-ID: <202508251436.762035B@keescook> References: <73764aaa-2186-4c8e-8523-55705018d842@lucifer.local> <69860c97-8a76-4ce5-b1d6-9d7c8370d9cd@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 16CDC140004 X-Stat-Signature: isgzkzanqkzt3hjrkmqpmfqqxcka1r7h X-Rspam-User: X-HE-Tag: 1756157844-221114 X-HE-Meta: U2FsdGVkX1/y6dyzAezs4Y+Q7jmWJI+E14UmMeVXo5+K4f4DNzs56627TlMo4UJjckLpv6T1HxOY68Vt/J8J5MYgm5YRoGEoGmuRfJ48QqGGgAs48DesGZQCXRPsatsHEG7ByHRKECNXyc6VELHT6DQlsgyMidatjjvJw35LZ80QuwRBKaic8+NOYNIgrX7bn6hN2pqOHYUt9hjQ83toqWJcOKOVVDkuj3M8peGUY9eXs6kJgfsqE0fgXlqd7Yk13ysw3+Nl242mnBrN5WQnYQ+/vWP71Co2r0Crw3MZq/K9JXksflx4NvHvDDW4gjkQkzyR5mg4Z8mJJucB5/C1wJByHSevNcQYFQ/CCJqYB4I2oUcUScyxCRMKQuPp8SYn+5G9G7KSFJQEEkNvwrkzuwXYorZTETZ0kuwrtPJP0sd6UVXuC/U/pM2IOR/lVW9hTG0xFIu3Dx2UQ3zf4zxcJiZepMkLYAcam0MSJu82Z+DmUPCyOrNpuaaWmVvUUGoooDrtOQbOKh9uI0MyUo5kuEzkSpRaCegKFM8lj3M1xBwzewABBiBuYT2OErGJWWUO6RuYrIrOMWY2M4seN5ODdU5gWavNKk547dsCC/H/GYiaY/hkXze8mRHDup5M/oRv52zdgQppo/FqL1x0ul7xgMp7VYIhPxTrtdV6st1qgnnM0KPkm+NH6ZhB6qrny0UwHCzJ9Y6Qoh9V4uIlrx/PYo1r6Lu3/5QLGz/32sTRwZTH0E2MgAksA1e6FQPUgW8yqBwyqsy6TW8J8iaFhRwvZ1guTDf+tS3DRcWyYdy3aKddHoJ+1awtFY/yp7Mribdq5b3KeGMW7EgmsDrLjEHgoHYnY8Duf4HoI7tiezHTx3Zm5nerDO4v330eWMNOpLp5bJyauBVcZJw5JxMEc6UDBbCJVjBJpyqmAN+eRT2ziffhbGAmG+xEPdVD/B3nX4Nl1Ivi6xNyTDPE+w0Dxy9 TJ9AfYx6 02gcG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 05, 2025 at 06:13:56PM +0200, Uladzislau Rezki wrote: > I agree. Also it can be even moved under vmalloc.c. There is only one > user which needs it globally, it is usercopy.c. It uses find_vmap_area() > which is wrong. See: > > > if (is_vmalloc_addr(ptr) && !pagefault_disabled()) { > struct vmap_area *area = find_vmap_area(addr); > > if (!area) > usercopy_abort("vmalloc", "no area", to_user, 0, n); > > if (n > area->va_end - addr) { > offset = addr - area->va_start; > usercopy_abort("vmalloc", NULL, to_user, offset, n); > } > return; > } > > > we can add a function which just assign va_start, va_end as input > parameters and use them in the usercopy.c. Yes please! I'd must rather use some exported validation routine than having it hand-coded in usercopy.c. :) -- Kees Cook