From: Andrew Morton <akpm@linux-foundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>,
kernel@collabora.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>,
Albert Ou <aou@eecs.berkeley.edu>, Zi Yan <ziy@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Suren Baghdasaryan <surenb@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Mike Rapoport <rppt@kernel.org>, Peter Xu <peterx@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Palmer Dabbelt <palmer@dabbelt.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Leon Romanovsky <leon@kernel.org>, Shuah Khan <shuah@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Alexandre Ghiti <alex@ghiti.fr>, Barry Song <baohua@kernel.org>,
Dev Jain <dev.jain@arm.com>,
linux-kselftest@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-mm@kvack.org, Nico Pache <npache@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2 4/8] selftests/mm: Add -Wunused family of flags
Date: Thu, 21 Aug 2025 15:13:08 -0700 [thread overview]
Message-ID: <20250821151308.915362b14e82f5626f659481@linux-foundation.org> (raw)
In-Reply-To: <4abd97fe-412d-4e3e-9efc-cf3092d66e57@collabora.com>
On Thu, 21 Aug 2025 17:31:21 +0500 Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
> > My
> > feeling is that unused parameters are expected to be allowed in the
> > kernel and it isn't helpful to go against that expectation in just a
> > small subset of kselftests.
> I thought kernel must be giving error for unused parameters as well (from
> my memory). But just checked and it doesn't seem like it. I'm okay with
> dropping -Wunused-parameters.
>
> We need to drop patch 6/7 and in Patch 4 should have only:
>
> -CFLAGS += -Wunused -Wunused-parameter -Wunused-function -Wunused-label -Wunused-variable -Wunused-value
> +CFLAGS += -Wunused
>
> @Andrew, Should I resend the entire series or would you can make the change?
I think a new series would be clearer, please. It's unclear (to me)
whether Kevin's various comments have all been addressed.
next prev parent reply other threads:[~2025-08-21 22:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 16:01 [PATCH v2 0/8] selftests/mm: Add compiler flags and fix found warnings Muhammad Usama Anjum
2025-07-31 16:01 ` [PATCH v2 1/8] selftests/mm: Add -Wunreachable-code and fix warnings Muhammad Usama Anjum
2025-07-31 16:32 ` Sidhartha Kumar
2025-08-18 8:10 ` Kevin Brodsky
2025-08-21 6:19 ` Muhammad Usama Anjum
2025-08-21 10:34 ` Kevin Brodsky
2025-07-31 16:01 ` [PATCH v2 2/8] selftests/mm: protection_keys: Fix dead code Muhammad Usama Anjum
2025-07-31 16:39 ` Sidhartha Kumar
2025-08-18 8:12 ` Kevin Brodsky
2025-07-31 16:01 ` [PATCH v2 3/8] selftests: kselftest.h: Add __unused macro Muhammad Usama Anjum
2025-08-02 23:35 ` John Hubbard
2025-07-31 16:01 ` [PATCH v2 4/8] selftests/mm: Add -Wunused family of flags Muhammad Usama Anjum
2025-08-18 8:16 ` Kevin Brodsky
2025-08-19 22:52 ` Andrew Morton
2025-08-21 6:28 ` Muhammad Usama Anjum
2025-08-21 10:43 ` Kevin Brodsky
2025-08-21 12:31 ` Muhammad Usama Anjum
2025-08-21 22:13 ` Andrew Morton [this message]
2025-07-31 16:01 ` [PATCH v2 5/8] selftests/mm: Remove unused parameters Muhammad Usama Anjum
2025-07-31 16:01 ` [PATCH v2 6/8] selftests/mm: Mark unused arguments with __unused Muhammad Usama Anjum
2025-07-31 16:01 ` [PATCH v2 7/8] " Muhammad Usama Anjum
2025-07-31 16:01 ` [PATCH v2 8/8] selftests/mm: Fix unused parameter warnings for different architectures Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821151308.915362b14e82f5626f659481@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kernel@collabora.com \
--cc=kevin.brodsky@arm.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.anjum@collabora.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox