From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: sj@kernel.org, honggyu.kim@sk.com
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
Sang-Heon Jeon <ekffu200098@gmail.com>
Subject: [PATCH] mm/damon/core: set initial quota->charged_from to INITIAL_JIFFIES
Date: Tue, 19 Aug 2025 03:38:03 +0900 [thread overview]
Message-ID: <20250818183803.1450539-1-ekffu200098@gmail.com> (raw)
Kernel initialize "jiffies" timer as 5 minutes below zero, as shown in
include/linux/jiffies.h
/*
* Have the 32 bit jiffies value wrap 5 minutes after boot
* so jiffies wrap bugs show up earlier.
*/
#define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-300*HZ))
In 32bit system, if quota->charged_from is initialized to 0 as it now,
it will not adjust event if reset_interval_ms passes for the first 5
minutes.
So change initialize value of quota->charged_from to INITIAL_JIFFIES.
This soultion has already been applied in commit 7d70e15480c0 ("writeback:
add missing INITIAL_JIFFIES init in global_update_bandwidth()") or else.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
I think it would be good to add selftest of below senario.
1. Set DAMON with quota.
2. Wait and check esz is updated well.
3. If esz is not updated after quite long time, set test to fail.
but I'm not sure that selftest can support environment handling; jiffies
with INITIAL_JIFFIES or near there.
If there is another method that i don't know. Could you please let me
know? Or any better idea?
---
mm/damon/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index cb41fddca78c..90317a3bcf78 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -366,7 +366,7 @@ static struct damos_quota *damos_quota_init(struct damos_quota *quota)
quota->total_charged_sz = 0;
quota->total_charged_ns = 0;
quota->charged_sz = 0;
- quota->charged_from = 0;
+ quota->charged_from = INITIAL_JIFFIES;
quota->charge_target_from = NULL;
quota->charge_addr_from = 0;
quota->esz_bp = 0;
--
2.43.0
next reply other threads:[~2025-08-18 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 18:38 Sang-Heon Jeon [this message]
2025-08-18 23:01 ` SeongJae Park
2025-08-19 1:52 ` Sang-Heon Jeon
2025-08-19 4:10 ` SeongJae Park
2025-08-19 5:25 ` SeongJae Park
2025-08-19 7:30 ` Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818183803.1450539-1-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=damon@lists.linux.dev \
--cc=honggyu.kim@sk.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox