From: Wei Yang <richard.weiyang@gmail.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, david@redhat.com, riel@surriel.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, harry.yoo@oracle.com,
linux-mm@kvack.org
Subject: Re: [PATCH 0/3] mm/rmap: small cleanup for __folio_remove_rmap()
Date: Sat, 16 Aug 2025 00:36:03 +0000 [thread overview]
Message-ID: <20250816003603.agl5ixvcfjqen4el@master> (raw)
In-Reply-To: <d9da4b04-7537-421e-b712-5e694056893a@lucifer.local>
On Fri, Aug 15, 2025 at 11:11:24AM +0100, Lorenzo Stoakes wrote:
>On Fri, Aug 15, 2025 at 08:49:40AM +0000, Wei Yang wrote:
>> During code reading, I found some small places where we can improve based on
>> the knowledge we already have.
>>
>> For example, since base folio is handled in another branch, we case use
>> folio_large_nr_pages() to get the number directly.
>
>I think this cover letter is pretty weak, please describe what you are
>doing clearly and why.
>
Will adjust it.
>>
>> Hope I don't mess it up.
>
>Please don't put this kind of thing in the cover letter, it gets reproduced
>into the actual commit messages and this isn't useful for people reading
>through commit messages.
>
Sure.
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2025-08-16 0:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 8:49 Wei Yang
2025-08-15 8:49 ` [PATCH 1/3] mm/rmap: not necessary to mask off FOLIO_PAGES_MAPPED Wei Yang
2025-08-15 9:38 ` Lorenzo Stoakes
2025-08-16 0:33 ` Wei Yang
2025-08-16 6:29 ` David Hildenbrand
2025-08-15 8:49 ` [PATCH 2/3] mm/rmap: could be partially_mapped only after no entire map Wei Yang
2025-08-15 10:08 ` Lorenzo Stoakes
2025-08-16 6:31 ` David Hildenbrand
2025-08-16 9:06 ` Wei Yang
2025-08-16 9:16 ` David Hildenbrand
2025-08-16 10:05 ` Giorgi Tchankvetadze
2025-08-16 10:32 ` David Hildenbrand
2025-08-16 14:03 ` Wei Yang
2025-08-15 8:49 ` [PATCH 3/3] mm/rmap: use folio_large_nr_pages() when we are sure it is a large folio Wei Yang
2025-08-15 10:04 ` Lorenzo Stoakes
2025-08-16 6:32 ` David Hildenbrand
2025-08-15 10:11 ` [PATCH 0/3] mm/rmap: small cleanup for __folio_remove_rmap() Lorenzo Stoakes
2025-08-16 0:36 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250816003603.agl5ixvcfjqen4el@master \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox