From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: sj@kernel.org, honggyu.kim@sk.com
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
Sang-Heon Jeon <ekffu200098@gmail.com>
Subject: [PATCH] mm/damon/core: fix damos_commit_filter not changing allow
Date: Fri, 15 Aug 2025 18:40:59 +0900 [thread overview]
Message-ID: <20250815094059.133769-1-ekffu200098@gmail.com> (raw)
Current damos_commit_filter() not persist allow value of filter. As a
result, changing allow value of filter and commit doesn't change
allow value.
Add the missing allow value update, so commit filter now persist changing
allow value well.
Fixes: 9cb3d0b9dfce ("mm/damon/core: implement DAMON context commit function")
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
While fixing kselftest, I found another bug and succeeded in
reproducing. I think this patch is similar with previeous patch [1].
Also instead of sending patch with test, should we check which is better:
a seperate patch or patchset?
[1] https://lore.kernel.org/damon/20250808220815.49644-1-sj@kernel.org/
---
mm/damon/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 19c8f01fc81a..cb41fddca78c 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -900,6 +900,7 @@ static void damos_commit_filter(
{
dst->type = src->type;
dst->matching = src->matching;
+ dst->allow = src->allow;
damos_commit_filter_arg(dst, src);
}
--
2.43.0
next reply other threads:[~2025-08-15 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 9:40 Sang-Heon Jeon [this message]
2025-08-15 17:25 ` SeongJae Park
2025-08-15 17:51 ` SeongJae Park
2025-08-16 1:18 ` Sang-Heon Jeon
2025-08-16 16:02 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815094059.133769-1-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=damon@lists.linux.dev \
--cc=honggyu.kim@sk.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox