From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Gu Bowen <gubowen5@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org, linux-mm@kvack.org,
Waiman Long <llong@redhat.com>, Breno Leitao <leitao@debian.org>,
John Ogness <john.ogness@linutronix.de>,
Lu Jialin <lujialin4@huawei.com>
Subject: Re: [PATCH v3] mm: Fix possible deadlock in console_trylock_spinning
Date: Thu, 14 Aug 2025 15:56:58 +0200 [thread overview]
Message-ID: <2025081450-tibia-angelfish-3aa2@gregkh> (raw)
In-Reply-To: <aJ3f05Dqzx0OouJa@arm.com>
On Thu, Aug 14, 2025 at 02:08:35PM +0100, Catalin Marinas wrote:
> On Thu, Aug 14, 2025 at 10:33:56AM +0800, Gu Bowen wrote:
> > On 8/14/2025 6:56 AM, Andrew Morton wrote:
> > > I'm not sure which kernel version this was against, but kmemleak.c has
> > > changed quite a lot.
> > >
> > > Could we please see a patch against a latest kernel version? Linus
> > > mainline will suit.
> > >
> > > Thanks.
> >
> > I discovered this issue in kernel version 5.10. Afterwards, I reviewed the
> > code of the mainline version and found that this deadlock path no longer
> > exists due to the refactoring of console_lock in v6.2-rc1. For details on
> > the refactoring, you can refer to this link :
> > https://lore.kernel.org/all/20221116162152.193147-1-john.ogness@linutronix.de/.
> > Therefore, theoretically, this issue existed before the refactoring of
> > console_lock.
>
> Oh, so you can no longer hit this issue with mainline. This wasn't
> mentioned (or I missed it) in the commit log.
>
> So this would be a stable-only fix that does not have a correspondent
> upstream. Adding Greg for his opinion.
Why not take the upstream changes instead?
next prev parent reply other threads:[~2025-08-14 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 8:53 Gu Bowen
2025-08-13 16:22 ` Catalin Marinas
2025-08-13 22:56 ` Andrew Morton
2025-08-14 2:33 ` Gu Bowen
2025-08-14 13:08 ` Catalin Marinas
2025-08-14 13:56 ` Greg Kroah-Hartman [this message]
2025-08-14 14:38 ` Catalin Marinas
2025-08-14 14:54 ` Greg Kroah-Hartman
2025-08-14 17:00 ` Catalin Marinas
2025-08-18 2:24 ` Gu Bowen
2025-08-18 5:54 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081450-tibia-angelfish-3aa2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=gubowen5@huawei.com \
--cc=john.ogness@linutronix.de \
--cc=leitao@debian.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=lujialin4@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox