From: Andrew Morton <akpm@linux-foundation.org>
To: <zhongjinji@honor.com>
Cc: <linux-mm@kvack.org>, <mhocko@suse.com>, <rientjes@google.com>,
<shakeel.butt@linux.dev>, <npache@redhat.com>,
<linux-kernel@vger.kernel.org>, <tglx@linutronix.de>,
<mingo@redhat.com>, <peterz@infradead.org>,
<dvhart@infradead.org>, <dave@stgolabs.net>,
<andrealmeid@igalia.com>, <liam.howlett@oracle.com>,
<liulu.liu@honor.com>, <feng.han@honor.com>,
Joel Savitz <jsavitz@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 0/3] mm/oom_kill: Only delay OOM reaper for processes using robust futexes
Date: Thu, 14 Aug 2025 16:13:45 -0700 [thread overview]
Message-ID: <20250814161345.b2ddf7120dfcc420c3199e67@linux-foundation.org> (raw)
In-Reply-To: <20250814135555.17493-1-zhongjinji@honor.com>
On Thu, 14 Aug 2025 21:55:52 +0800 <zhongjinji@honor.com> wrote:
> The OOM reaper quickly reclaims a process's memory when the system hits OOM,
> helping the system recover. Without the OOM reaper, if a process frozen by
> cgroup v1 is OOM killed, the victim's memory cannot be freed, leaving the
> system in a poor state. Even if the process is not frozen by cgroup v1,
> reclaiming victims' memory remains important, as having one more process
> working speeds up memory release.
>
> When processes holding robust futexes are OOM killed but waiters on those
> futexes remain alive, the robust futexes might be reaped before
> futex_cleanup() runs. This can cause the waiters to block indefinitely [1].
>
> To prevent this issue, the OOM reaper's work is delayed by 2 seconds [1]. Since
> many killed processes exit within 2 seconds, the OOM reaper rarely runs after
> this delay. However, robust futex users are few, so delaying OOM reap for all
> victims is unnecessary.
>
> If each thread's robust_list in a process is NULL, the process holds no robust
> futexes. For such processes, the OOM reaper should not be delayed. For
> processes holding robust futexes, to avoid issue [1], the OOM reaper must
> still be delayed.
>
> Patch 1 introduces process_has_robust_futex() to detect whether a process uses
> robust futexes. Patch 2 delays the OOM reaper only for processes holding robust
> futexes, improving OOM reaper performance. Patch 3 makes the OOM reaper and
> exit_mmap() traverse the maple tree in opposite orders to reduce PTE lock
> contention caused by unmapping the same vma.
This all sounds sensible, given that we appear to be stuck with the
2-second hack.
What prevents one of the process's threads from creating a robust mutex
after we've inspected it with process_has_robust_futex()?
next prev parent reply other threads:[~2025-08-14 23:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 13:55 zhongjinji
2025-08-14 13:55 ` [PATCH v4 1/3] futex: Introduce function process_has_robust_futex() zhongjinji
2025-08-14 13:55 ` [PATCH v4 2/3] mm/oom_kill: Only delay OOM reaper for processes using robust futexes zhongjinji
2025-08-15 14:41 ` Lorenzo Stoakes
2025-08-18 14:14 ` zhongjinji
2025-08-17 19:37 ` Michal Hocko
2025-08-18 12:08 ` zhongjinji
2025-08-19 10:49 ` Michal Hocko
2025-08-20 2:53 ` Davidlohr Bueso
2025-08-21 18:13 ` Michal Hocko
2025-08-21 19:45 ` Davidlohr Bueso
2025-08-14 13:55 ` [PATCH v4 3/3] mm/oom_kill: Have the OOM reaper and exit_mmap() traverse the maple tree in opposite orders zhongjinji
2025-08-14 23:09 ` Andrew Morton
2025-08-15 16:32 ` zhongjinji
2025-08-15 17:52 ` gio
2025-08-15 17:53 ` gio
2025-08-15 14:29 ` Lorenzo Stoakes
2025-08-15 15:01 ` Lorenzo Stoakes
2025-08-15 17:37 ` zhongjinji
2025-08-19 15:18 ` zhongjinji
2025-08-21 9:32 ` Lorenzo Stoakes
2025-08-25 14:12 ` zhongjinji
2025-08-15 14:41 ` Liam R. Howlett
2025-08-15 16:05 ` Liam R. Howlett
2025-08-14 23:13 ` Andrew Morton [this message]
2025-08-15 17:06 ` [PATCH v4 0/3] mm/oom_kill: Only delay OOM reaper for processes using robust futexes zhongjinji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814161345.b2ddf7120dfcc420c3199e67@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=feng.han@honor.com \
--cc=jsavitz@redhat.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liulu.liu@honor.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=npache@redhat.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=shakeel.butt@linux.dev \
--cc=tglx@linutronix.de \
--cc=zhongjinji@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox