From: Andrew Morton <akpm@linux-foundation.org>
To: Gu Bowen <gubowen5@huawei.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
<stable@vger.kernel.org>, <linux-mm@kvack.org>,
Waiman Long <llong@redhat.com>, Breno Leitao <leitao@debian.org>,
John Ogness <john.ogness@linutronix.de>,
Lu Jialin <lujialin4@huawei.com>
Subject: Re: [PATCH v3] mm: Fix possible deadlock in console_trylock_spinning
Date: Wed, 13 Aug 2025 15:56:16 -0700 [thread overview]
Message-ID: <20250813155616.d7e5a832ce7cda7764942d10@linux-foundation.org> (raw)
In-Reply-To: <20250813085310.2260586-1-gubowen5@huawei.com>
On Wed, 13 Aug 2025 16:53:10 +0800 Gu Bowen <gubowen5@huawei.com> wrote:
> Our syztester report the lockdep WARNING [1]. kmemleak_scan_thread()
> invokes scan_block() which may invoke a nomal printk() to print warning
> message. This can cause a deadlock in the scenario reported below:
>
> CPU0 CPU1
> ---- ----
> lock(kmemleak_lock);
> lock(&port->lock);
> lock(kmemleak_lock);
> lock(console_owner);
>
> To solve this problem, switch to printk_safe mode before printing warning
> message, this will redirect all printk()-s to a special per-CPU buffer,
> which will be flushed later from a safe context (irq work), and this
> deadlock problem can be avoided. The proper API to use should be
> printk_deferred_enter()/printk_deferred_exit() if we want to deferred the
> printing [2].
>
> This patch also fixes other similar case that need to use the printk
> deferring [3].
>
> ...
>
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
I'm not sure which kernel version this was against, but kmemleak.c has
changed quite a lot.
Could we please see a patch against a latest kernel version? Linus
mainline will suit.
Thanks.
next prev parent reply other threads:[~2025-08-13 22:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 8:53 Gu Bowen
2025-08-13 16:22 ` Catalin Marinas
2025-08-13 22:56 ` Andrew Morton [this message]
2025-08-14 2:33 ` Gu Bowen
2025-08-14 13:08 ` Catalin Marinas
2025-08-14 13:56 ` Greg Kroah-Hartman
2025-08-14 14:38 ` Catalin Marinas
2025-08-14 14:54 ` Greg Kroah-Hartman
2025-08-14 17:00 ` Catalin Marinas
2025-08-18 2:24 ` Gu Bowen
2025-08-18 5:54 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813155616.d7e5a832ce7cda7764942d10@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=gubowen5@huawei.com \
--cc=john.ogness@linutronix.de \
--cc=leitao@debian.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=lujialin4@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox