From: SeongJae Park <sj@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
honggyu.kim@sk.com, damon@lists.linux.dev, linux-mm@kvack.org,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] selftests/damon: fix selftests by installing drgn related script
Date: Tue, 12 Aug 2025 10:59:39 -0700 [thread overview]
Message-ID: <20250812175939.57506-1-sj@kernel.org> (raw)
In-Reply-To: <20250812140046.660486-1-ekffu200098@gmail.com>
On Tue, 12 Aug 2025 23:00:46 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> drgn_dump_damon_status is not installed while kselftest setup.
> It can breaks other tests which depend on drgn_dump_damon_status.
> Install drgn_dump_damon_status files to fix broken test.
This patch conflicts with the similar one from Alexandre Ghiti. Could you
please rebase yours on top of Alexandre's one (and mention the dependency on
the comment section under '---' line), unless Andrew resolves the conflict on
his own?
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
> ---
> While setup kselftest executable environment and test this patch [1],
> I found similiar issue. Honestly, I don't know exact solution for this
> situation. So I just make a new patch. Sorry if it is wrong direction,
> then please let me know how to do next.
>
> [1] https://lore.kernel.org/damon/20250812-alex-fixes_manual-v1-1-c4e99b1f80e4@rivosinc.com/
For patches that you are not really confident about and hence not insisting to
merge as-is, but wanna ask other's opinions first, you can ask questions via
plain text mails, or post patches with RFC tag on the subject.
I think this is the right patch, though.
You could refer to the TEST_FILES part of documentation[1] and "Install
selftests" section on the document for more details.
[1] https://origin.kernel.org/doc/html/latest/dev-tools/kselftest.html#contributing-new-tests-details
Thanks,
SJ
[...]
next prev parent reply other threads:[~2025-08-12 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 14:00 Sang-Heon Jeon
2025-08-12 17:59 ` SeongJae Park [this message]
2025-08-12 22:17 ` Andrew Morton
2025-08-13 2:29 ` Sang-Heon Jeon
2025-08-13 2:24 ` Sang-Heon Jeon
2025-08-13 2:45 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812175939.57506-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexghiti@rivosinc.com \
--cc=damon@lists.linux.dev \
--cc=ekffu200098@gmail.com \
--cc=honggyu.kim@sk.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox