From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: sj@kernel.org, honggyu.kim@sk.com
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
Sang-Heon Jeon <ekffu200098@gmail.com>
Subject: [PATCH 2/2] mm/damon/core : fix commit_ops_filters by using correct nth function
Date: Sat, 9 Aug 2025 04:55:18 +0900 [thread overview]
Message-ID: <20250808195518.563053-3-ekffu200098@gmail.com> (raw)
In-Reply-To: <20250808195518.563053-1-ekffu200098@gmail.com>
damos_commit_ops_filters() incorrectly uses damos_nth_filter() which
iterates core_filters. As a result, performing a commit unintentionally
corrupts ops_filters.
Add damos_nth_ops_filter() which iterates ops_filters. Use this function
to fix issues caused by wrong iteration.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
mm/damon/core.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 883d791a10e5..19c8f01fc81a 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -862,6 +862,18 @@ static struct damos_filter *damos_nth_filter(int n, struct damos *s)
return NULL;
}
+static struct damos_filter *damos_nth_ops_filter(int n, struct damos *s)
+{
+ struct damos_filter *filter;
+ int i = 0;
+
+ damos_for_each_ops_filter(filter, s) {
+ if (i++ == n)
+ return filter;
+ }
+ return NULL;
+}
+
static void damos_commit_filter_arg(
struct damos_filter *dst, struct damos_filter *src)
{
@@ -925,7 +937,7 @@ static int damos_commit_ops_filters(struct damos *dst, struct damos *src)
int i = 0, j = 0;
damos_for_each_ops_filter_safe(dst_filter, next, dst) {
- src_filter = damos_nth_filter(i++, src);
+ src_filter = damos_nth_ops_filter(i++, src);
if (src_filter)
damos_commit_filter(dst_filter, src_filter);
else
--
2.43.0
next prev parent reply other threads:[~2025-08-08 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 19:55 [PATCH 0/2] fix damos_commit_ops_filters iteration problem with Sang-Heon Jeon
2025-08-08 19:55 ` [PATCH 1/2] selftests/damon: test no-op commit broke DAMON status Sang-Heon Jeon
2025-08-08 22:05 ` SeongJae Park
2025-08-09 6:27 ` Sang-Heon Jeon
2025-08-09 6:39 ` Sang-Heon Jeon
2025-08-09 17:35 ` SeongJae Park
2025-08-10 5:43 ` Sang-Heon Jeon
2025-08-08 19:55 ` Sang-Heon Jeon [this message]
2025-08-08 22:08 ` [PATCH 2/2] mm/damon/core : fix commit_ops_filters by using correct nth function SeongJae Park
2025-08-08 23:26 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808195518.563053-3-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=damon@lists.linux.dev \
--cc=honggyu.kim@sk.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox