From: Kairui Song <ryncsn@gmail.com>
To: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>,
David Hildenbrand <david@redhat.com>,
Chris Li <chrisl@kernel.org>, Barry Song <baohua@kernel.org>,
Baoquan He <bhe@redhat.com>, Nhat Pham <nphamcs@gmail.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
linux-kernel@vger.kernel.org, Kairui Song <kasong@tencent.com>
Subject: [RFC PATCH 0/3] mm/mincore: clean up swap cache helper and PTL
Date: Thu, 7 Aug 2025 23:27:17 +0800 [thread overview]
Message-ID: <20250807152720.62032-1-ryncsn@gmail.com> (raw)
From: Kairui Song <kasong@tencent.com>
There is a swap cache helper that is only used by mincore. It was
seperated out from mincore some time ago to be shared with other users,
but now mincore is the only user again. So it can be easily merged back
to simplify the code.
Patch 1 clean this up, but I'm not very sure about Patch 2 and 3:
Realizing that the PTL seems only useful for stablizing the swap
cache space now, by grabbing the swap device before looking up the swap
cache space (patch 2), we can drop the PTL locking (patch 3).
Let me know if I'm missing something. With mmap lock, the mincore result
should be reliable enough without the PTL.
Kairui Song (3):
mm/mincore, swap: consolidate swap cache checking for mincore
mm/mincore: use a helper for checking the swap cache
mm/mincore: avoid touching the PTL
mm/mincore.c | 53 ++++++++++++++++++++++++++++++++++++++-----------
mm/swap.h | 10 ----------
mm/swap_state.c | 38 -----------------------------------
3 files changed, 41 insertions(+), 60 deletions(-)
--
2.50.1
next reply other threads:[~2025-08-07 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 15:27 Kairui Song [this message]
2025-08-07 15:27 ` [RFC PATCH 1/3] mm/mincore, swap: consolidate swap cache checking for mincore Kairui Song
2025-08-07 18:06 ` Nhat Pham
2025-08-07 18:23 ` Kairui Song
2025-08-07 15:27 ` [RFC PATCH 2/3] mm/mincore: use a helper for checking the swap cache Kairui Song
2025-08-07 15:27 ` [RFC PATCH 3/3] mm/mincore: avoid touching the PTL Kairui Song
2025-08-07 16:02 ` Jann Horn
2025-08-07 17:27 ` Kairui Song
2025-08-07 17:45 ` Jann Horn
2025-08-07 18:09 ` Kairui Song
2025-08-11 8:41 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807152720.62032-1-ryncsn@gmail.com \
--to=ryncsn@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=nphamcs@gmail.com \
--cc=pfalcato@suse.de \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox